You are viewing a plain text version of this content. The canonical link for it is here.
Posted to general@incubator.apache.org by James Taylor <ja...@apache.org> on 2018/05/08 18:42:38 UTC
Re: [VOTE] Release Apache Omid 0.9.0.0 (incubating)
@Justin - thanks for taking the time to review. Really appreciate it. Looks
like there's some confusion, though. Prior to starting this vote, you
approved the change on the JIRA here[1], but now you've -1'ed the release.
At this point, we're trying to get clarification on OMID-44 so that when we
go through another vote, we make sure we've done it correctly.
Would you have time to please review the change on the JIRA so we can spin
up the next RC?
Thanks,
James
[1]
https://issues.apache.org/jira/browse/OMID-44?focusedCommentId=16424626&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16424626
On Fri, Apr 13, 2018 at 8:47 AM, Matt Sicker <bo...@gmail.com> wrote:
> The protobuf issue I was able to fix locally by installing protobuf@2.6
> (homebrew) and modifying my PATH for the build command. I still had failing
> tests, though.
>
> On 12 April 2018 at 19:23, Justin Mclean <ju...@classsoftware.com> wrote:
>
> > Hi,
> >
> > -1 binding as NOTICE is incorrect. The NOTICE file need to be keep as
> > small as possible [1]
> >
> > I checked:
> > - incubating in file name
> > - signatures good although it would be best to sign with an apache.org
> > email address
> > - LICENSE is fine
> > - NOTICE file contains wrong year (2016) and incorrectly lists files that
> > have 3rd party ALv2 headers. Where did these files come from? It looks
> like
> > here [4] which has a NOTICE file [4]
> > - a couple of files are missing ASF headers [2][3]
> > - no unexpected binary files
> > - Can't compile from source. Looks like I have a newer version of
> > protobuf. May be an issue for other people as well?
> >
> > Not 100% certain but I think that the NOTICE file [5] needs to be taken
> > into account, however it may be that the version of the files you have
> were
> > taken when no NOTICE files existed? (It was committed in 2014? and the
> > copyright is 2010 on those files.)
> >
> > Thanks,
> > Justin
> >
> > 1. http://www.apache.org/dev/licensing-howto.html#mod-notice
> > 2. apache-omid-incubating-0.9.0.0-src/tso-server/src/main/
> > resources/default-omid-server-configuration.yml
> > 3. apache-omid-incubating-0.9.0.0-src/benchmarks/src/main/
> > resources/default-tso-server-benchmark-config.yml
> > 4.https://github.com/linkedin/MTBT/
> > 5. https://github.com/linkedin/MTBT/blob/master/NOTICE
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: general-help@incubator.apache.org
> >
> >
>
>
> --
> Matt Sicker <bo...@gmail.com>
>
Re: [VOTE] Release Apache Omid 0.9.0.0 (incubating)
Posted by Justin Mclean <ju...@me.com>.
Hi,
> Could you please review the notice file in OMID-44
> <https://issues.apache.org/jira/browse/OMID-44> before I'll cook a new
> release candidate?
I’ve taken a look at NOTICE file now looks good. However where did those yahoo files come from? If it was from here [3] then you need to add this:
This product includes software developed by
Yahoo! Inc. (www.yahoo.com)
Copyright (c) 2010 Yahoo! Inc. All rights reserved.
to the notice file as that is in the projects NOTICE file. [4]
You may also want to add the license for [1] (and other files) to LICENSE. It’s not required but a good idea to do so. [2]
Thanks,
Jutsin
1. https://github.com/apache/incubator-omid/blob/0c371361781957c96b20295290a167f7be3b33e2/benchmarks/src/main/java/org/apache/omid/benchmarks/utils/Generator.java
2. http://www.apache.org/dev/licensing-howto.html#alv2-dep
3. https://github.com/mdhim/ycsb
4. https://github.com/mdhim/ycsb/blob/master/NOTICE.txt
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache Omid 0.9.0.0 (incubating)
Posted by Ohad Shacham <oh...@oath.com.INVALID>.
Thanks Justin.
Could you please review the notice file in OMID-44
<https://issues.apache.org/jira/browse/OMID-44> before I'll cook a new
release candidate?
Thanks,
Ohad
On Thu, May 10, 2018 at 2:13 AM, Justin Mclean <ju...@classsoftware.com>
wrote:
> Hi,
>
> > Has the project taken YCSB notice file into account [1] and can you
> confirm YCSB has taken MTBT notice file into account [2]. From a casual
> look (and I could be mistaken) this doesn’t seem to be the case.
>
> BTW I don’t think this is a major issue and it can be fine in a later
> release if needed.
>
> Thanks,
> Justin
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>
Re: [VOTE] Release Apache Omid 0.9.0.0 (incubating)
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> Has the project taken YCSB notice file into account [1] and can you confirm YCSB has taken MTBT notice file into account [2]. From a casual look (and I could be mistaken) this doesn’t seem to be the case.
BTW I don’t think this is a major issue and it can be fine in a later release if needed.
Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache Omid 0.9.0.0 (incubating)
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> Both MTBT and Omid took files from YCSB, therefore, I don’t understand why
> we should take MTBT’s NOTICE file into account?
Has the project taken YCSB notice file into account [1] and can you confirm YCSB has taken MTBT notice file into account [2]. From a casual look (and I could be mistaken) this doesn’t seem to be the case.
Thanks,
Justin
1. https://github.com/brianfrankcooper/YCSB/blob/master/NOTICE.txt
2. https://github.com/linkedin/MTBT/blob/master/NOTICE
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache Omid 0.9.0.0 (incubating)
Posted by Ohad Shacham <oh...@oath.com.INVALID>.
Hi,
Both MTBT and Omid took files from YCSB, therefore, I don’t understand why
we should take MTBT’s NOTICE file into account?
Thx,
Ohad
On Wed, May 9, 2018 at 5:14 AM, Justin Mclean <ju...@me.com> wrote:
> Hi,
>
> > @Justin - thanks for taking the time to review. Really appreciate it.
> Looks
> > like there's some confusion, though. Prior to starting this vote, you
> > approved the change on the JIRA here[1], but now you've -1'ed the
> release.
>
> AFAICS this is still unanswered:
>
> Not 100% certain but I think that the NOTICE file [5] needs to be taken
> into account, however it may be that the version of the files you have were
> taken when no NOTICE files existed? (It was committed in 2014? and the
> copyright is 2010 on those files.)
>
> Thanks,
> Justin
>
> 5. https://github.com/linkedin/MTBT/blob/master/NOTICE <
> https://github.com/linkedin/MTBT/blob/master/NOTICE>
Re: [VOTE] Release Apache Omid 0.9.0.0 (incubating)
Posted by Justin Mclean <ju...@me.com>.
Hi,
> @Justin - thanks for taking the time to review. Really appreciate it. Looks
> like there's some confusion, though. Prior to starting this vote, you
> approved the change on the JIRA here[1], but now you've -1'ed the release.
AFAICS this is still unanswered:
Not 100% certain but I think that the NOTICE file [5] needs to be taken into account, however it may be that the version of the files you have were taken when no NOTICE files existed? (It was committed in 2014? and the copyright is 2010 on those files.)
Thanks,
Justin
5. https://github.com/linkedin/MTBT/blob/master/NOTICE <https://github.com/linkedin/MTBT/blob/master/NOTICE>