You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2019/12/21 15:58:51 UTC
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue
#1537: refactor zk client and zk config module
codecov-io edited a comment on issue #1537: refactor zk client and zk config module
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1537#issuecomment-568188281
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1537?src=pr&el=h1) Report
> Merging [#1537](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1537?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/d52a83bfcf27ac1d226f6644d29fc1909e555b6e?src=pr&el=desc) will **decrease** coverage by `0.15%`.
> The diff coverage is `8.87%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1537/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1537?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1537 +/- ##
========================================
- Coverage 7.42% 7.27% -0.16%
========================================
Files 272 278 +6
Lines 13634 13738 +104
Branches 2169 2196 +27
========================================
- Hits 1012 999 -13
- Misses 12555 12674 +119
+ Partials 67 65 -2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1537?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...e/dolphinscheduler/server/worker/WorkerServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1537/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9Xb3JrZXJTZXJ2ZXIuamF2YQ==) | `0% <ø> (ø)` | :arrow_up: |
| [.../org/apache/dolphinscheduler/common/Constants.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1537/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL0NvbnN0YW50cy5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
| [...e/dolphinscheduler/common/zk/AbstractZKClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1537/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3prL0Fic3RyYWN0WktDbGllbnQuamF2YQ==) | `0% <0%> (-15.24%)` | :arrow_down: |
| [.../dolphinscheduler/common/zk/ZookeeperOperator.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1537/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3prL1pvb2tlZXBlck9wZXJhdG9yLmphdmE=) | `0% <0%> (ø)` | |
| [...e/dolphinscheduler/api/utils/ZookeeperMonitor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1537/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3V0aWxzL1pvb2tlZXBlck1vbml0b3IuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: |
| [...che/dolphinscheduler/server/zk/ZKWorkerClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1537/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3prL1pLV29ya2VyQ2xpZW50LmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
| [...inscheduler/common/zk/ZookeeperCachedOperator.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1537/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3prL1pvb2tlZXBlckNhY2hlZE9wZXJhdG9yLmphdmE=) | `0% <0%> (ø)` | |
| [...e/dolphinscheduler/server/master/MasterServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1537/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9NYXN0ZXJTZXJ2ZXIuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: |
| [...e/dolphinscheduler/api/service/MonitorService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1537/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvTW9uaXRvclNlcnZpY2UuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: |
| [...che/dolphinscheduler/server/zk/ZKMasterClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1537/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3prL1pLTWFzdGVyQ2xpZW50LmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
| ... and [13 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1537/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1537?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1537?src=pr&el=footer). Last update [d52a83b...8133768](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1537?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services