You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by cui dt <cu...@outlook.com> on 2018/06/15 00:08:54 UTC
Review Request 67609: Added DaoTan Cui to the contributors list.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67609/
-----------------------------------------------------------
Review request for mesos and Gilbert Song.
Repository: mesos
Description
-------
Added DaoTan Cui to the contributors list.
Diffs
-----
docs/contributors.yaml 6a5b215050c8c4ac2b4416ec4afad8265a4d394a
Diff: https://reviews.apache.org/r/67609/diff/1/
Testing
-------
Thanks,
cui dt
Re: Review Request 67609: Added DaoTan Cui to the contributors list.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67609/#review205199
-----------------------------------------------------------
Fix it, then Ship it!
docs/contributors.yaml
Lines 268-274 (patched)
<https://reviews.apache.org/r/67609/#comment288129>
one more slot up. I will fix it for you :)
- Gilbert Song
On June 19, 2018, 10:56 a.m., cui dt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67609/
> -----------------------------------------------------------
>
> (Updated June 19, 2018, 10:56 a.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added DaoTan Cui to the contributors list.
>
>
> Diffs
> -----
>
> docs/contributors.yaml c46795aa83f2f1cb93464500a0be1aafbfe5e60f
>
>
> Diff: https://reviews.apache.org/r/67609/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> cui dt
>
>
Re: Review Request 67609: Added DaoTan Cui to the contributors list.
Posted by cui dt <cu...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67609/
-----------------------------------------------------------
(Updated 六月 19, 2018, 5:56 p.m.)
Review request for mesos and Gilbert Song.
Repository: mesos
Description
-------
Added DaoTan Cui to the contributors list.
Diffs (updated)
-----
docs/contributors.yaml c46795aa83f2f1cb93464500a0be1aafbfe5e60f
Diff: https://reviews.apache.org/r/67609/diff/2/
Changes: https://reviews.apache.org/r/67609/diff/1-2/
Testing
-------
Thanks,
cui dt
Re: Review Request 67609: Added DaoTan Cui to the contributors list.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67609/#review204985
-----------------------------------------------------------
Fix it, then Ship it!
docs/contributors.yaml
Lines 285 (patched)
<https://reviews.apache.org/r/67609/#comment287830>
Would you mind sort it alphabetically?
e.g., right above `Dario Rexin`
- Gilbert Song
On June 14, 2018, 5:08 p.m., cui dt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67609/
> -----------------------------------------------------------
>
> (Updated June 14, 2018, 5:08 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added DaoTan Cui to the contributors list.
>
>
> Diffs
> -----
>
> docs/contributors.yaml 6a5b215050c8c4ac2b4416ec4afad8265a4d394a
>
>
> Diff: https://reviews.apache.org/r/67609/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> cui dt
>
>
Re: Review Request 67609: Added DaoTan Cui to the contributors list.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67609/#review204815
-----------------------------------------------------------
PASS: Mesos patch 67609 was successfully built and tested.
Reviews applied: `['67609']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67609
- Mesos Reviewbot Windows
On June 14, 2018, 5:08 p.m., cui dt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67609/
> -----------------------------------------------------------
>
> (Updated June 14, 2018, 5:08 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added DaoTan Cui to the contributors list.
>
>
> Diffs
> -----
>
> docs/contributors.yaml 6a5b215050c8c4ac2b4416ec4afad8265a4d394a
>
>
> Diff: https://reviews.apache.org/r/67609/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> cui dt
>
>
Re: Review Request 67609: Added DaoTan Cui to the contributors list.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67609/#review204854
-----------------------------------------------------------
Patch looks great!
Reviews applied: [67609]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On June 15, 2018, 12:08 a.m., cui dt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67609/
> -----------------------------------------------------------
>
> (Updated June 15, 2018, 12:08 a.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added DaoTan Cui to the contributors list.
>
>
> Diffs
> -----
>
> docs/contributors.yaml 6a5b215050c8c4ac2b4416ec4afad8265a4d394a
>
>
> Diff: https://reviews.apache.org/r/67609/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> cui dt
>
>