[GitHub] [openwhisk-wskdebug] alexkli commented on issue #54: use docker api client instead of `docker` child process

[GitBox <gi...@apache.org>]

alexkli commented on issue #54:
URL: https://github.com/apache/openwhisk-wskdebug/issues/54#issuecomment-616834385


   It seems the problem with VS Code stopping after the `docker kill` step is not due to it being a separate process execution. Same behavior if I replace it with `dockerrode` (which uses a socket to the docker daemon). If I add longer async requests (e.g. http requests using `fetch`) they work fine.
   
   The issue really is that as soon as the debug port is gone, which is what docker kill does, VS code detects that and kills the `wskdebug` process, or at least stops the log output.
   
   We might address that by changing the order of shutdown, so that killing the container is the last crucial item.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org