You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2019/04/25 16:24:32 UTC
[Impala-ASF-CR] Remove hive-benchmark test workload
Hello Tim Armstrong,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/13117
to review the following change.
Change subject: Remove hive-benchmark test workload
......................................................................
Remove hive-benchmark test workload
This workload was added in 2012 or so, and hasn't actually been able to
run in years:
- fails to load because the name has a '-' in it, and we use unquoted
database names in the load script
- the SQL to load it seems to refer to testdata files which don't
exist
Even if it did load, it looks like it's only a set of ~10 trivial
queries which I doubt have any real benchmark interest in modern days.
Change-Id: I383638ef4acce59792fee287da0016b3d949e693
---
M testdata/bin/generate-schema-statements.py
M testdata/datasets/README
D testdata/datasets/hive-benchmark/hive-benchmark_schema_template.sql
M testdata/datasets/tpcds/tpcds_schema_template.sql
M testdata/datasets/tpch/tpch_schema_template.sql
D testdata/workloads/hive-benchmark/hive-benchmark_core.csv
D testdata/workloads/hive-benchmark/hive-benchmark_dimensions.csv
D testdata/workloads/hive-benchmark/hive-benchmark_exhaustive.csv
D testdata/workloads/hive-benchmark/hive-benchmark_pairwise.csv
D testdata/workloads/hive-benchmark/queries/hive-benchmark.test
10 files changed, 34 insertions(+), 215 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/17/13117/1
--
To view, visit http://gerrit.cloudera.org:8080/13117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I383638ef4acce59792fee287da0016b3d949e693
Gerrit-Change-Number: 13117
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] Remove hive-benchmark test workload
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13117 )
Change subject: Remove hive-benchmark test workload
......................................................................
Remove hive-benchmark test workload
This workload was added in 2012 or so, and hasn't actually been able to
run in years:
- fails to load because the name has a '-' in it, and we use unquoted
database names in the load script
- the SQL to load it seems to refer to testdata files which don't
exist
Even if it did load, it looks like it's only a set of ~10 trivial
queries which I doubt have any real benchmark interest in modern days.
Change-Id: I383638ef4acce59792fee287da0016b3d949e693
Reviewed-on: http://gerrit.cloudera.org:8080/13117
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M testdata/bin/generate-schema-statements.py
M testdata/datasets/README
D testdata/datasets/hive-benchmark/hive-benchmark_schema_template.sql
M testdata/datasets/tpcds/tpcds_schema_template.sql
M testdata/datasets/tpch/tpch_schema_template.sql
D testdata/workloads/hive-benchmark/hive-benchmark_core.csv
D testdata/workloads/hive-benchmark/hive-benchmark_dimensions.csv
D testdata/workloads/hive-benchmark/hive-benchmark_exhaustive.csv
D testdata/workloads/hive-benchmark/hive-benchmark_pairwise.csv
D testdata/workloads/hive-benchmark/queries/hive-benchmark.test
10 files changed, 34 insertions(+), 215 deletions(-)
Approvals:
Tim Armstrong: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/13117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I383638ef4acce59792fee287da0016b3d949e693
Gerrit-Change-Number: 13117
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[Impala-ASF-CR] Remove hive-benchmark test workload
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13117 )
Change subject: Remove hive-benchmark test workload
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4067/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/13117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I383638ef4acce59792fee287da0016b3d949e693
Gerrit-Change-Number: 13117
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Apr 2019 17:13:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Remove hive-benchmark test workload
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13117 )
Change subject: Remove hive-benchmark test workload
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/13117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I383638ef4acce59792fee287da0016b3d949e693
Gerrit-Change-Number: 13117
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Apr 2019 22:29:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Remove hive-benchmark test workload
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13117 )
Change subject: Remove hive-benchmark test workload
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2913/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I383638ef4acce59792fee287da0016b3d949e693
Gerrit-Change-Number: 13117
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Apr 2019 17:11:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Remove hive-benchmark test workload
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13117 )
Change subject: Remove hive-benchmark test workload
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I383638ef4acce59792fee287da0016b3d949e693
Gerrit-Change-Number: 13117
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Apr 2019 17:02:22 +0000
Gerrit-HasComments: No