You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/08 15:33:57 UTC

[GitHub] [incubator-nuttx] hartmannathan opened a new pull request #2244: tiva/cc13x2_cc26x2: Fix nxstyle errors

hartmannathan opened a new pull request #2244:
URL: https://github.com/apache/incubator-nuttx/pull/2244


   ## Summary
   
   arch/arm/src/tiva/hardware/cc13x2_cc26x2/cc13x2_cc26x2_flash.h:
   
   - Fix nxstyle errors.
   
   ## Impact
   
   Removes nxstyle errors.
   
   ## Testing
   
   nxstyle


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] hartmannathan commented on a change in pull request #2244: tiva/cc13x2_cc26x2: Fix nxstyle errors

Posted by GitBox <gi...@apache.org>.
hartmannathan commented on a change in pull request #2244:
URL: https://github.com/apache/incubator-nuttx/pull/2244#discussion_r519477500



##########
File path: arch/arm/src/tiva/hardware/cc13x2_cc26x2/cc13x2_cc26x2_flash.h
##########
@@ -993,10 +1002,15 @@
 #define FLASH_FSM_EXECUTE_SUSPEND_NOW_MASK   (15 << FLASH_FSM_EXECUTE_SUSPEND_NOW_SHIFT)
 
 /* TIVA_FLASH_FSM_SECTOR1 (32-bit value) */
+

Review comment:
       Done. See [PR-2250](https://github.com/apache/incubator-nuttx/pull/2250)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] hartmannathan commented on a change in pull request #2244: tiva/cc13x2_cc26x2: Fix nxstyle errors

Posted by GitBox <gi...@apache.org>.
hartmannathan commented on a change in pull request #2244:
URL: https://github.com/apache/incubator-nuttx/pull/2244#discussion_r519476295



##########
File path: arch/arm/src/tiva/hardware/cc13x2_cc26x2/cc13x2_cc26x2_flash.h
##########
@@ -993,10 +1002,15 @@
 #define FLASH_FSM_EXECUTE_SUSPEND_NOW_MASK   (15 << FLASH_FSM_EXECUTE_SUSPEND_NOW_SHIFT)
 
 /* TIVA_FLASH_FSM_SECTOR1 (32-bit value) */
+

Review comment:
       Oops it looks like that was intended to be a single section separator for several similar registers. Sorry. It's been merged already. I can make another PR to make them a single comment.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] Ouss4 merged pull request #2244: tiva/cc13x2_cc26x2: Fix nxstyle errors

Posted by GitBox <gi...@apache.org>.
Ouss4 merged pull request #2244:
URL: https://github.com/apache/incubator-nuttx/pull/2244


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] btashton commented on a change in pull request #2244: tiva/cc13x2_cc26x2: Fix nxstyle errors

Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #2244:
URL: https://github.com/apache/incubator-nuttx/pull/2244#discussion_r519453012



##########
File path: arch/arm/src/tiva/hardware/cc13x2_cc26x2/cc13x2_cc26x2_flash.h
##########
@@ -728,12 +730,19 @@
 #define FLASH_FTCTL_WDATA_BLK_CLR            (1 << 16) /* Bit 16 */
 
 /* TIVA_FLASH_FWPWRITE0 (32-bit value) */
+

Review comment:
       Any reason to not make this one block comment instead?

##########
File path: arch/arm/src/tiva/hardware/cc13x2_cc26x2/cc13x2_cc26x2_flash.h
##########
@@ -993,10 +1002,15 @@
 #define FLASH_FSM_EXECUTE_SUSPEND_NOW_MASK   (15 << FLASH_FSM_EXECUTE_SUSPEND_NOW_SHIFT)
 
 /* TIVA_FLASH_FSM_SECTOR1 (32-bit value) */
+

Review comment:
       Same question about making it a block comment




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] btashton commented on a change in pull request #2244: tiva/cc13x2_cc26x2: Fix nxstyle errors

Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #2244:
URL: https://github.com/apache/incubator-nuttx/pull/2244#discussion_r519480003



##########
File path: arch/arm/src/tiva/hardware/cc13x2_cc26x2/cc13x2_cc26x2_flash.h
##########
@@ -993,10 +1002,15 @@
 #define FLASH_FSM_EXECUTE_SUSPEND_NOW_MASK   (15 << FLASH_FSM_EXECUTE_SUSPEND_NOW_SHIFT)
 
 /* TIVA_FLASH_FSM_SECTOR1 (32-bit value) */
+

Review comment:
       No worries. It was my fault, the GitHub mobile app changed the default to make it a pending review and I forgot to submit it at the end.
   
   Thanks for doing all of these. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org