You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/11 18:02:37 UTC

[GitHub] [spark] dongjoon-hyun edited a comment on issue #27540: Revert "[SPARK-28093][SQL] Fix TRIM/LTRIM/RTRIM function parameter order issue"

dongjoon-hyun edited a comment on issue #27540: Revert "[SPARK-28093][SQL] Fix TRIM/LTRIM/RTRIM function parameter order issue"
URL: https://github.com/apache/spark/pull/27540#issuecomment-584770474
 
 
   @cloud-fan , @HyukjinKwon , @gatorsmile .
   For this reverting, I believe we need to discuss on the mailing list first.
   I'm okay that we need to choose one way(this reverting) or the other(the previous one).
   But, without explicit discussion, I'm -1 for this reverting PR. This PR should not land on `master`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org