You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by wr...@apache.org on 2002/02/05 00:37:37 UTC

cvs commit: httpd-2.0/server/mpm/winnt mpm_winnt.c

wrowe       02/02/04 15:37:37

  Modified:    server/mpm/winnt mpm_winnt.c
  Log:
    Fixed for the recent apr-ized logfile changes.  The Win32 service never
    has a STDERR channel in the first place, so the first ap_open_stderr_log()
    fails.  We need to open it after we've initialized the service control
    manager and created the stderr pipe thread that logs stderr output over
    in our Application Event Log.
  
    The failure message still looks pretty danged stupid on WinXP however;
    "The Apache2 service on Local Computer started and then stopped."
    [ok, that part is straightforward.]  "Some services stop automatically
    if they have no work to do, for example, the Performance Logs and
    Alerts service."  [that's the bogus bit.]
  
  Revision  Changes    Path
  1.216     +3 -1      httpd-2.0/server/mpm/winnt/mpm_winnt.c
  
  Index: mpm_winnt.c
  ===================================================================
  RCS file: /home/cvs/httpd-2.0/server/mpm/winnt/mpm_winnt.c,v
  retrieving revision 1.215
  retrieving revision 1.216
  diff -u -r1.215 -r1.216
  --- mpm_winnt.c	1 Feb 2002 22:16:31 -0000	1.215
  +++ mpm_winnt.c	4 Feb 2002 23:37:37 -0000	1.216
  @@ -1895,8 +1895,10 @@
            */
           if (osver.dwPlatformId == VER_PLATFORM_WIN32_NT) {
               service_to_start_success = mpm_service_to_start(&service_name);
  -            if (service_to_start_success == APR_SUCCESS)
  +            if (service_to_start_success == APR_SUCCESS) {
                   service_set = APR_SUCCESS;
  +                ap_open_stderr_log(process->pool);
  +            }
           }
       }