You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/11/02 21:17:58 UTC
[jira] [Commented] (TINKERPOP-1434) Block calls to traversal
side-effects until read is complete
[ https://issues.apache.org/jira/browse/TINKERPOP-1434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15630562#comment-15630562 ]
ASF GitHub Bot commented on TINKERPOP-1434:
-------------------------------------------
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/479
TINKERPOP-1434 Block calls on "remote" traversal to get side-effects
https://issues.apache.org/jira/browse/TINKERPOP-1434
This prevents calls for side-effects that are not yet ready on the server. This was generally a problem in tests, but users could have also run afoul of the issue if they decided to get low-level with the API. It is more likely that they would grab side-effects with a call to `cap()` so this would be a non-issue in that case.
Did multiple runs of `mvn clean install && mvn verify -pl gremlin-server -DincludeNeo4j -DskipIntegrationTests=false` and it passes nicely. I never saw the test failures that triggered the effort to produce a fix for this problem, so @dkuppitz who saw it regularly should give this a review. Also, if travis passes, that would be a good sign - the error was seen there sometimes as well. Please be sure to use `-DincludeNeo4j` if re-running the tests.
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1434
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/479.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #479
----
commit 46a61bb124d27aebcf96a639b2614e16389b02f9
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2016-11-02T21:12:36Z
TINKERPOP-1434 Block calls on "remote" traversal to get side-effects
This prevents calls for side-effects that are not yet ready on the server. This was generally a problem in tests, but usrs could have also run afoul of the issue if they decided to get low-level with the API. It is more likely that they would grab side-effects with a call to cap() so this would be a non-issue in that case.
----
> Block calls to traversal side-effects until read is complete
> ------------------------------------------------------------
>
> Key: TINKERPOP-1434
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1434
> Project: TinkerPop
> Issue Type: Improvement
> Components: driver
> Affects Versions: 3.2.2
> Reporter: stephen mallette
> Assignee: stephen mallette
> Priority: Minor
>
> Might make usability a little better if calls to {{getSideEffects()}} could block until the remote {{Traversal}} complete iteration (i.e. on "read complete") - or perhaps they return a {{Future}} or something.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)