You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by "kumaab (via GitHub)" <gi...@apache.org> on 2026/01/21 23:28:32 UTC

[PR] RANGER-5301: Fix InvalidDefaultArgInFrom Warnings in docker build [ranger]

kumaab opened a new pull request, #813:
URL: https://github.com/apache/ranger/pull/813

   ## What changes were proposed in this pull request?
   
   Warnings from BuildKit during the docker build:
   
   ```
   2025-08-29T04:59:18.8132073Z #2 WARN: InvalidDefaultArgInFrom: Default value for ARG ${RANGER_BASE_IMAGE}:${RANGER_BASE_VERSION} results in empty or invalid base image name (line 20)
   2025-08-29T04:59:18.8133508Z #2 WARN: InvalidDefaultArgInFrom: Default value for ARG ranger_${RANGER_DB_TYPE} results in empty or invalid base image name (line 61)
   ```
   
   To silence these warnings, the best way seems to be to use sentinel placeholders instead of duplicating raw values from `.env` file. Maintaining versions in multiple files is an overhead so using placeholders is a good approach to take.
   
   
   ## How was this patch tested?
   Pending
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] RANGER-5301: Fix InvalidDefaultArgInFrom Warnings in docker build [ranger]

Posted by "mneethiraj (via GitHub)" <gi...@apache.org>.
mneethiraj commented on code in PR #813:
URL: https://github.com/apache/ranger/pull/813#discussion_r2719741840


##########
dev-support/ranger-docker/Dockerfile.ranger:
##########
@@ -13,9 +13,9 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
-ARG RANGER_DB_TYPE
-ARG RANGER_BASE_IMAGE
-ARG RANGER_BASE_VERSION
+ARG RANGER_DB_TYPE=postgres

Review Comment:
   Following 4 docker files have actual values as default while other files have a marker value. Is this intentional?
   - Dockerfile.ranger
   - Dockerfile.ranger-kms
   - Dockerfile.ranger-tagsync
   - Dockerfile.ranger-usersync



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] RANGER-5301: Fix InvalidDefaultArgInFrom Warnings in docker build [ranger]

Posted by "kumaab (via GitHub)" <gi...@apache.org>.
kumaab merged PR #813:
URL: https://github.com/apache/ranger/pull/813


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] RANGER-5301: Fix InvalidDefaultArgInFrom Warnings in docker build [ranger]

Posted by "kumaab (via GitHub)" <gi...@apache.org>.
kumaab commented on code in PR #813:
URL: https://github.com/apache/ranger/pull/813#discussion_r2723311839


##########
dev-support/ranger-docker/Dockerfile.ranger:
##########
@@ -13,9 +13,9 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
-ARG RANGER_DB_TYPE
-ARG RANGER_BASE_IMAGE
-ARG RANGER_BASE_VERSION
+ARG RANGER_DB_TYPE=postgres

Review Comment:
   Yes, this was done for testing purposes, I'll update all Dockerfiles to have default values: the values need not change with time since docker compose uses .env to override.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org