You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sirona.apache.org by rm...@apache.org on 2015/11/11 07:15:19 UTC

svn commit: r1713767 - /incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/AgentContext.java

Author: rmannibucau
Date: Wed Nov 11 06:15:19 2015
New Revision: 1713767

URL: http://svn.apache.org/viewvc?rev=1713767&view=rev
Log:
no need to sort each time we filter listeners if the original list is sorted

Modified:
    incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/AgentContext.java

Modified: incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/AgentContext.java
URL: http://svn.apache.org/viewvc/incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/AgentContext.java?rev=1713767&r1=1713766&r2=1713767&view=diff
==============================================================================
--- incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/AgentContext.java (original)
+++ incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/AgentContext.java Wed Nov 11 06:15:19 2015
@@ -100,7 +100,7 @@ public class AgentContext {
     }
 
     private static InvocationListener[] loadAllListeners() {
-        final Collection<InvocationListener> listeners = new LinkedList<InvocationListener>();
+        final List<InvocationListener> listeners = new LinkedList<InvocationListener>();
 
         ClassLoader agentLoader = AgentContext.class.getClassLoader();
         if (agentLoader == null) {
@@ -118,7 +118,7 @@ public class AgentContext {
                 }
             }
         }
-        //System.out.println("listeners:" + listeners.toString());
+        Collections.sort(listeners, ListenerComparator.INSTANCE); // sort them here to avoid to resort the list each time then
         return listeners.toArray(new InvocationListener[listeners.size()]);
     }
 
@@ -158,7 +158,6 @@ public class AgentContext {
                 listeners.add(listener);
             }
         }
-        Collections.sort( listeners, ListenerComparator.INSTANCE );
         return listeners.toArray(new InvocationListener[listeners.size()]);
     }