You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/01/31 18:43:08 UTC
[GitHub] [nifi-registry] bbende opened a new pull request #256: NIFIREG-356 Fixing additional classpath resources for Authorizers and…
bbende opened a new pull request #256: NIFIREG-356 Fixing additional classpath resources for Authorizers and…
URL: https://github.com/apache/nifi-registry/pull/256
… ensuring proper context ClassLoader is set
The original problem I was setting out to solve is what was described in the JIRA where didn't do anything with the classpathResources here:
https://github.com/apache/nifi-registry/blob/master/nifi-registry-core/nifi-registry-framework/src/main/java/org/apache/nifi/registry/security/authorization/AuthorizerFactory.java#L340
It turned out there were a few other issues too...
- The introduction of the "FrameworkAuthorizer" broke some of the logic in the AuthorizerFactory that was trying to wrap the onConfigured call with the appropriate context ClassLoader
- The creation of the UGP, AP, and Authorizer should also set the context ClassLoader so it is set during the call to initialize, this is consistent with these methods on NiFi side
- The integrity checks and framework authorizer shouldn't be installed inside createAuthorizer, there could be multiple authorizers and it should only be done around the selected one
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi-registry] mcgilman commented on issue #256: NIFIREG-356 Fixing additional classpath resources for Authorizers and…
Posted by GitBox <gi...@apache.org>.
mcgilman commented on issue #256: NIFIREG-356 Fixing additional classpath resources for Authorizers and…
URL: https://github.com/apache/nifi-registry/pull/256#issuecomment-582431896
Will review...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi-registry] mcgilman commented on issue #256: NIFIREG-356 Fixing additional classpath resources for Authorizers and…
Posted by GitBox <gi...@apache.org>.
mcgilman commented on issue #256: NIFIREG-356 Fixing additional classpath resources for Authorizers and…
URL: https://github.com/apache/nifi-registry/pull/256#issuecomment-583457903
Thanks for the PR @bbende! This have been merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi-registry] asfgit closed pull request #256: NIFIREG-356 Fixing additional classpath resources for Authorizers and…
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #256: NIFIREG-356 Fixing additional classpath resources for Authorizers and…
URL: https://github.com/apache/nifi-registry/pull/256
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services