[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

[GitBox <gi...@apache.org>]

tkalkirill commented on code in PR #1506:
URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072180599


##########
modules/storage-api/src/testFixtures/java/org/apache/ignite/internal/storage/AbstractMvTableStorageTest.java:
##########
@@ -88,25 +92,46 @@ public abstract class AbstractMvTableStorageTest extends BaseMvStoragesTest {
     /** Partition id for 1 storage. */
     protected static final int PARTITION_ID_1 = 1 << 8;
 
-    private MvTableStorage tableStorage;
+    protected MvTableStorage tableStorage;
 
     private TableIndexView sortedIdx;
 
     private TableIndexView hashIdx;
 
+    private StorageEngine storageEngine;
+
     /**
      * Initializes the internal structures needed for tests.
      *
      * <p>This method *MUST* always be called in either subclass' constructor or setUp method.
      */
-    protected final void initialize(MvTableStorage tableStorage, TablesConfiguration tablesCfg) {
-        createTestTable(tableStorage.configuration());
-        createTestIndexes(tablesCfg);
+    protected final void initialize(StorageEngine storageEngine, TablesConfiguration tablesConfig) {
+        createTestTable(getTableConfig(tablesConfig));
+        createTestIndexes(tablesConfig);
+
+        this.storageEngine = storageEngine;

Review Comment:
   Makes sense, fixed it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org