[GitHub] [druid] cryptoe commented on pull request #12573: fix(druid-indexing): failed to get shardSpec for interval issue

[GitBox <gi...@apache.org>]

cryptoe commented on PR #12573:
URL: https://github.com/apache/druid/pull/12573#issuecomment-1145175355

   Hey I looked at the change. The change itself is small but can have a large impact. 
   Can you please explain the statement : 
   `I think it's safe to convert the interval timezone to UTC, so getSequenceName will return the right sequence name instead of throw the exception.` 
   Is there a reason why you think so ?
   It would be cool if you can add some ut's. Have a look at `PartialHashSegmentGenerateTaskTest#testCreateHashPartitionAnalysisFromPartitionsSpecWithNumShardsReturningAnalysisOfValidNumBuckets` 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org