[GitHub] [mynewt-core] andrzej-kaczmarek commented on a diff in pull request #2915: apps: Allow stub/full implementation of packages in syscfg

[GitBox <gi...@apache.org>]

andrzej-kaczmarek commented on code in PR #2915:
URL: https://github.com/apache/mynewt-core/pull/2915#discussion_r1056253553


##########
apps/bleprph_oic/pkg.yml:
##########
@@ -30,10 +30,10 @@ pkg.deps:
     - "@apache-mynewt-nimble/nimble/host/services/gatt"
     - "@apache-mynewt-nimble/nimble/host/store/config"
     - "@apache-mynewt-nimble/nimble/transport"
-    - "@apache-mynewt-core/sys/console/full"
-    - "@apache-mynewt-core/sys/log/full"
+    - "@apache-mynewt-core/sys/console/"

Review Comment:
   remove trailing `/`



##########
apps/bleprph_oic/syscfg.yml:
##########
@@ -25,6 +25,10 @@ syscfg.defs:
         value: 0
 
 syscfg.vals:
+    CONSOLE_MODE: full

Review Comment:
   I do not recall if we have `CONSOLE_MODE` instead of `CONSOLE_IMPLEMENTATION` for a reason, but if it's just for 'historical reasons' we should add `CONSOLE_IMPLEMENTATION` and deprecate `CONSOLE_MODE`.
   
   @kasjer ^^ ?



##########
sys/stats/pkg.yml:
##########
@@ -0,0 +1,31 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#  http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+pkg.name: sys/stats
+pkg.description: API common to both the full and stub log implementations.
+pkg.author: "Apache Mynewt <de...@mynewt.apache.org>"
+pkg.homepage: "http://mynewt.apache.org/"

Review Comment:
   https



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org