You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by yu...@apache.org on 2026/08/20 12:51:36 UTC
(gluten) branch main updated: [MINOR][VL] re-enable the tests on Char/VarChar (#12811)
This is an automated email from the ASF dual-hosted git repository.
zhouyuan pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gluten.git
The following commit(s) were added to refs/heads/main by this push:
new 38c7b47e0d [MINOR][VL] re-enable the tests on Char/VarChar (#12811)
38c7b47e0d is described below
commit 38c7b47e0d3eb1a8656456d29e9b174df9a8ac69
Author: Yuan <yu...@apache.org>
AuthorDate: Thu Aug 20 13:51:30 2026 +0100
[MINOR][VL] re-enable the tests on Char/VarChar (#12811)
---
.../scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala | 4 ----
.../scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala | 8 --------
.../scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala | 8 --------
3 files changed, 20 deletions(-)
diff --git a/gluten-ut/spark35/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala b/gluten-ut/spark35/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
index 22c72ba392..e7a8c93ba8 100644
--- a/gluten-ut/spark35/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
+++ b/gluten-ut/spark35/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
@@ -628,8 +628,6 @@ class VeloxTestSettings extends BackendTestSettings {
.exclude("length check for input string values: nested in map value")
.exclude("length check for input string values: nested in both map key and value")
.exclude("length check for input string values: nested in array of struct")
- .excludeGlutenTest("length check for input string values: nested in array of struct")
- .exclude("char type values should be padded: nested in array of struct")
.exclude("length check for input string values: nested in array of array")
// Following tests are excluded as these are overridden in Gluten test suite..
// The overridden tests assert against Velox-specific error messages for char/varchar
@@ -647,8 +645,6 @@ class VeloxTestSettings extends BackendTestSettings {
.exclude("length check for input string values: nested in array")
.exclude("length check for input string values: nested in struct of array")
.exclude("length check for input string values: nested in array of struct")
- .excludeGlutenTest("length check for input string values: nested in array of struct")
- .exclude("char type values should be padded: nested in array of struct")
.exclude("length check for input string values: nested in array of array")
.exclude("length check for input string values: with implicit cast")
.exclude("char/varchar type values length check: partitioned columns of other types")
diff --git a/gluten-ut/spark40/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala b/gluten-ut/spark40/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
index 2e068639f9..f12483655b 100644
--- a/gluten-ut/spark40/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
+++ b/gluten-ut/spark40/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
@@ -949,15 +949,7 @@ class VeloxTestSettings extends BackendTestSettings {
// Rewrite for different cache size.
.exclude("SPARK-36120: Support cache/uncache table with TimestampNTZ type")
enableSuite[GlutenFileSourceCharVarcharTestSuite]
- // Velox Parquet writer (post dft-2026_08_12) introduced selective per-column flattening
- // that misses CONSTANT-encoded descendants inside nested complex types (ARRAY<STRUCT>).
- // Writes to ARRAY<STRUCT<char/varchar>> crash with VeloxRuntimeError INVALID_STATE in the
- // Arrow bridge instead of producing the expected error or result.
- .exclude("length check for input string values: nested in array of struct")
- .exclude("char type values should be padded: nested in array of struct")
enableSuite[GlutenDSV2CharVarcharTestSuite]
- .exclude("length check for input string values: nested in array of struct")
- .exclude("char type values should be padded: nested in array of struct")
enableSuite[GlutenColumnExpressionSuite]
// Velox raise_error('errMsg') throws a velox_user_error exception with the message 'errMsg'.
// The final caught Spark exception's getCause().getMessage() contains 'errMsg' but does not
diff --git a/gluten-ut/spark41/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala b/gluten-ut/spark41/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
index e027321f18..b196f7351f 100644
--- a/gluten-ut/spark41/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
+++ b/gluten-ut/spark41/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
@@ -933,15 +933,7 @@ class VeloxTestSettings extends BackendTestSettings {
.exclude("SPARK-36120: Support cache/uncache table with TimestampNTZ type")
enableSuite[GlutenCacheTableInKryoSuite]
enableSuite[GlutenFileSourceCharVarcharTestSuite]
- // Velox Parquet writer (post dft-2026_08_12) introduced selective per-column flattening
- // that misses CONSTANT-encoded descendants inside nested complex types (ARRAY<STRUCT>).
- // Writes to ARRAY<STRUCT<char/varchar>> crash with VeloxRuntimeError INVALID_STATE in the
- // Arrow bridge instead of producing the expected error or result.
- .exclude("length check for input string values: nested in array of struct")
- .exclude("char type values should be padded: nested in array of struct")
enableSuite[GlutenDSV2CharVarcharTestSuite]
- .exclude("length check for input string values: nested in array of struct")
- .exclude("char type values should be padded: nested in array of struct")
enableSuite[GlutenColumnExpressionSuite]
// Velox raise_error('errMsg') throws a velox_user_error exception with the message 'errMsg'.
// The final caught Spark exception's getCause().getMessage() contains 'errMsg' but does not
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org