[jira] [Resolved] (CB-9163) Make engines error look less nasty

["Steve Gill (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CB-9163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steve Gill resolved CB-9163.
----------------------------
    Resolution: Fixed
      Assignee: Steve Gill

Fixed. Nicer output and plugin gets skipped instead of throwing an error when engine check not met. 

> Make engines error look less nasty
> ----------------------------------
>
>                 Key: CB-9163
>                 URL: https://issues.apache.org/jira/browse/CB-9163
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib, Plugin Whitelist
>         Environment: iOS
>            Reporter: Shazron Abdullah
>            Assignee: Steve Gill
>              Labels: cordova-ios-4.0.x
>
> When installing the cordova-plugin-whitelist plugin (from master), and it doesn't fulfill the engine requirement, you get a scary error which is harmless.
> {code}
> $ cordova plugin add https://github.com/apache/cordova-plugin-whitelist.git#master
> Fetching plugin "https://github.com/apache/cordova-plugin-whitelist.git" via git clone
> Repository "https://github.com/apache/cordova-plugin-whitelist.git" checked out to git ref "master".
> Installing "cordova-plugin-whitelist" for android
> Installing "cordova-plugin-whitelist" for ios
> Failed to install 'cordova-plugin-whitelist':CordovaError: Plugin doesn't support this project's cordova-ios version. cordova-ios: 3.8.0, failed version requirement: >=4.0.0-dev
>     at checkEngines (/Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/src/plugman/install.js:119:29)
>     at /Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/src/plugman/install.js:296:16
>     at _fulfilled (/Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/node_modules/q/q.js:787:54)
>     at self.promiseDispatch.done (/Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/node_modules/q/q.js:816:30)
>     at Promise.promise.promiseDispatch (/Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/node_modules/q/q.js:749:13)
>     at /Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/node_modules/q/q.js:557:44
>     at flush (/Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/node_modules/q/q.js:108:17)
>     at process._tickCallback (node.js:419:13)
> Plugin doesn't support this project's cordova-ios version. cordova-ios: 3.8.0, failed version requirement: >=4.0.0-dev
> {code}
> Change it to not have the stack-trace, and have a friendlier output. If you have the Android platform added, it succeeds in installing it also, but not sure if its because the platform tag appears first in plugin.xml (check).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org