You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@carbondata.apache.org by Jay357089 <gi...@git.apache.org> on 2016/09/22 13:40:08 UTC

[GitHub] incubator-carbondata pull request #192: [WIP]change delete segment parsre

GitHub user Jay357089 opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/192

    [WIP]change delete segment parsre

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Jay357089/incubator-carbondata masterparser

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/192.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #192
    
----
commit f4abecc6e970c9af7eb34c3e81fe333b86d1aaf6
Author: Jay357089 <li...@huawei.com>
Date:   2016-09-22T12:40:28Z

    change parsre

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata pull request #192: [CARBONDATA-269]change delete segmen...

Posted by ManoharVanam <gi...@git.apache.org>.
Github user ManoharVanam commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/192#discussion_r80060992
  
    --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/CarbonSqlParser.scala ---
    @@ -1181,23 +1182,21 @@ class CarbonSqlParser()
             p.getClass.getSimpleName.equals("DecimalLit") } ) ^^ (_.chars)
     
       protected lazy val deleteLoadsByID: Parser[LogicalPlan] =
    -    DELETE ~> SEGMENT ~> repsep(segmentId, ",") ~ (FROM ~> TABLE ~>
    -      (ident <~ ".").? ~ ident) <~
    +    DELETE ~> FROM ~ TABLE ~> (ident <~ ".").? ~ ident ~
    +      (WHERE ~> SEGMENT ~> EQUAL ~> repsep(segmentId, ",")) <~
    --- End diff --
    
    I think its better to use segments in both places deleteLoadsByID , deleteLoadsByLoadDate to avoid confusion


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata pull request #192: [CARBONDATA-269]change delete segmen...

Posted by Jay357089 <gi...@git.apache.org>.
Github user Jay357089 closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/192


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---