You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by Trustin Lee <tr...@gmail.com> on 2005/10/07 07:05:31 UTC
Re: svn commit: r307017 - in /directory/apacheds/trunk: core/src/main/java/org/apache/ldap/server/configuration/ main/src/main/java/org/apache/ldap/server/configuration/
Do we need accessControlEnabled property here? Can user just insert or
remove AuthorizationService?
Trustin
2005/10/7, akarasulu@apache.org <ak...@apache.org>:
>
> Author: akarasulu
> Date: Thu Oct 6 21:59:13 2005
> New Revision: 307017
>
> URL: http://svn.apache.org/viewcvs?rev=307017&view=rev
> Log:
> fixed little issue with spring not having a mutable property for
> accessControlEnabled
>
> Modified:
>
> directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/configuration/MutableStartupConfiguration.java
>
> directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/configuration/StartupConfiguration.java
>
> directory/apacheds/trunk/main/src/main/java/org/apache/ldap/server/configuration/MutableServerStartupConfiguration.java
>
> Modified:
> directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/configuration/MutableStartupConfiguration.java
> URL:
> http://svn.apache.org/viewcvs/directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/configuration/MutableStartupConfiguration.java?rev=307017&r1=307016&r2=307017&view=diff
>
> ==============================================================================
> ---
> directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/configuration/MutableStartupConfiguration.java
> (original)
> +++
> directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/configuration/MutableStartupConfiguration.java
> Thu Oct 6 21:59:13 2005
> @@ -70,9 +70,9 @@
> super.setContextPartitionConfigurations( contextParitionConfigurations );
> }
>
> - public void setAccessControlEnabled( boolean isAccessControlEnabled )
> + public void setAccessControlEnabled( boolean accessControlEnabled )
> {
> - super.setAccessControlEnabled( isAccessControlEnabled );
> + super.setAccessControlEnabled( accessControlEnabled );
> }
>
> public void setAllowAnonymousAccess( boolean enableAnonymousAccess )
>
> Modified:
> directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/configuration/StartupConfiguration.java
> URL:
> http://svn.apache.org/viewcvs/directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/configuration/StartupConfiguration.java?rev=307017&r1=307016&r2=307017&view=diff
>
> ==============================================================================
> ---
> directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/configuration/StartupConfiguration.java
> (original)
> +++
> directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/configuration/StartupConfiguration.java
> Thu Oct 6 21:59:13 2005
> @@ -44,7 +44,7 @@
>
> /**
> * A {@link Configuration} that starts up ApacheDS.
> - *
> + *
> * @author <a href="mailto:dev@directory.apache.org">Apache Directory
> Project</a>
> * @version $Rev$, $Date$
> */
> @@ -280,9 +280,9 @@
> /**
> * Sets whether to enable basic access control checks or not
> */
> - protected void setAccessControlEnabled( boolean isAccessControlEnabled )
> + protected void setAccessControlEnabled( boolean accessControlEnabled )
> {
> - this.accessControlEnabled = isAccessControlEnabled;
> + this.accessControlEnabled = accessControlEnabled;
> }
>
> /**
>
> Modified:
> directory/apacheds/trunk/main/src/main/java/org/apache/ldap/server/configuration/MutableServerStartupConfiguration.java
> URL:
> http://svn.apache.org/viewcvs/directory/apacheds/trunk/main/src/main/java/org/apache/ldap/server/configuration/MutableServerStartupConfiguration.java?rev=307017&r1=307016&r2=307017&view=diff
>
> ==============================================================================
> ---
> directory/apacheds/trunk/main/src/main/java/org/apache/ldap/server/configuration/MutableServerStartupConfiguration.java
> (original)
> +++
> directory/apacheds/trunk/main/src/main/java/org/apache/ldap/server/configuration/MutableServerStartupConfiguration.java
> Thu Oct 6 21:59:13 2005
> @@ -40,6 +40,11 @@
> super();
> }
>
> + public void setAccessControlEnabled( boolean accessControlEnabled )
> + {
> + super.setAccessControlEnabled( accessControlEnabled );
> + }
> +
> public void setAllowAnonymousAccess( boolean arg0 )
> {
> super.setAllowAnonymousAccess( arg0 );
>
>
>
--
what we call human nature is actually human habit
--
http://gleamynode.net/
Re: svn commit: r307017 - in /directory/apacheds/trunk: core/src/main/java/org/apache/ldap/server/configuration/
main/src/main/java/org/apache/ldap/server/configuration/
Posted by Alex Karasulu <ao...@bellsouth.net>.
Trustin Lee wrote:
> Do we need accessControlEnabled property here? Can user just insert
> or remove AuthorizationService?
That's more of a configuration pain. Adding and removing the Authz
service can cause more errors and user needs to remember package/class
name etc. This way users can toggle true/false property to control one
or more authz services.
Plus as touched on above one or more Authz service may be in use. We
may have in one service for rule-based-access-control and another for
basic-access-control etc.
Alex