You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/03/17 03:45:27 UTC
[kudu-CR] WIP [release notes] supported NTP servers and new time source
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15456
Change subject: WIP [release notes] supported NTP servers and new time source
......................................................................
WIP [release notes] supported NTP servers and new time source
WIP:
* I have some doubts about having the time about the newly introduced
time source souce `system_unsync` in the relase notes.
Should we leave that with the explanation that it's only for POC/toy
one-node Kudu clusters (as it's phrased now) or drop the whole
mention about the newly introduced time source completely?
* This patch should be in the release notes for 1.12 release, not in
the main branch.
DONT_BUILD
Change-Id: I70c2075c73693cc9605372ea5b58044ebbf93bdf
---
M docs/release_notes.adoc
1 file changed, 14 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/15456/1
--
To view, visit http://gerrit.cloudera.org:8080/15456
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I70c2075c73693cc9605372ea5b58044ebbf93bdf
Gerrit-Change-Number: 15456
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] WIP [release notes] supported NTP servers and time source
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has abandoned this change. ( http://gerrit.cloudera.org:8080/15456 )
Change subject: WIP [release notes] supported NTP servers and time source
......................................................................
Abandoned
This has been integrated into https://gerrit.cloudera.org/#/c/15685/
--
To view, visit http://gerrit.cloudera.org:8080/15456
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I70c2075c73693cc9605372ea5b58044ebbf93bdf
Gerrit-Change-Number: 15456
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Lieber-Dembo <ad...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] WIP [release notes] supported NTP servers and time source
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15456 )
Change subject: WIP [release notes] supported NTP servers and time source
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15456/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/15456/2//COMMIT_MSG@13
PS2, Line 13: DONT_BUILD
> FYI you don't need this for docs changes anymore after:
That's nice, thank you for the heads-up.
I'm planning to merge this patch into 1.12 release notes when the branch is forked.
--
To view, visit http://gerrit.cloudera.org:8080/15456
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I70c2075c73693cc9605372ea5b58044ebbf93bdf
Gerrit-Change-Number: 15456
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 24 Mar 2020 03:57:49 +0000
Gerrit-HasComments: Yes
[kudu-CR] WIP [release notes] supported NTP servers and time source
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15456 )
Change subject: WIP [release notes] supported NTP servers and time source
......................................................................
Patch Set 2: Code-Review+2
Seems good to me.
--
To view, visit http://gerrit.cloudera.org:8080/15456
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I70c2075c73693cc9605372ea5b58044ebbf93bdf
Gerrit-Change-Number: 15456
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 17 Mar 2020 16:59:36 +0000
Gerrit-HasComments: No
[kudu-CR] WIP [release notes] supported NTP servers and time source
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15456
to look at the new patch set (#2).
Change subject: WIP [release notes] supported NTP servers and time source
......................................................................
WIP [release notes] supported NTP servers and time source
WIP:
* This patch should be in the release notes for 1.12 release, not in
the main branch.
DONT_BUILD
Change-Id: I70c2075c73693cc9605372ea5b58044ebbf93bdf
---
M docs/release_notes.adoc
1 file changed, 8 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/15456/2
--
To view, visit http://gerrit.cloudera.org:8080/15456
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I70c2075c73693cc9605372ea5b58044ebbf93bdf
Gerrit-Change-Number: 15456
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] WIP [release notes] supported NTP servers and time source
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15456 )
Change subject: WIP [release notes] supported NTP servers and time source
......................................................................
Patch Set 2:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/15456/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/15456/1//COMMIT_MSG@13
PS1, Line 13:
:
> +1. Let's not tell people about it at all.
Thank you for the feedback!
http://gerrit.cloudera.org:8080/#/c/15456/1/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/15456/1/docs/release_notes.adoc@48
PS1, Line 48: == Optimizations and improvements
> I might also doc that the built-in client is now fully supported (i.e. not
Done
http://gerrit.cloudera.org:8080/#/c/15456/1/docs/release_notes.adoc@49
PS1, Line 49: The built-in NTP client is now ful
> Nit: `chronyd` (version 3.4 and newer) is now supported...
Done
http://gerrit.cloudera.org:8080/#/c/15456/1/docs/release_notes.adoc@50
PS1, Line 50: l. To switch the
: time source from the existing `system` time source (which is the default)
: to the built-in NTP client, use `--time_
> I don't think we need to say this.
Done
--
To view, visit http://gerrit.cloudera.org:8080/15456
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I70c2075c73693cc9605372ea5b58044ebbf93bdf
Gerrit-Change-Number: 15456
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 17 Mar 2020 07:55:48 +0000
Gerrit-HasComments: Yes
[kudu-CR] WIP [release notes] supported NTP servers and time source
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15456 )
Change subject: WIP [release notes] supported NTP servers and time source
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15456/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/15456/2//COMMIT_MSG@13
PS2, Line 13: DONT_BUILD
FYI you don't need this for docs changes anymore after:
https://gerrit.cloudera.org/#/c/15481/
--
To view, visit http://gerrit.cloudera.org:8080/15456
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I70c2075c73693cc9605372ea5b58044ebbf93bdf
Gerrit-Change-Number: 15456
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 23 Mar 2020 18:05:21 +0000
Gerrit-HasComments: Yes
[kudu-CR] WIP [release notes] supported NTP servers and new time source
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15456 )
Change subject: WIP [release notes] supported NTP servers and new time source
......................................................................
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/15456/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/15456/1//COMMIT_MSG@13
PS1, Line 13: drop the whole
: mention about the newly introduced time source completely?
+1. Let's not tell people about it at all.
http://gerrit.cloudera.org:8080/#/c/15456/1/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/15456/1/docs/release_notes.adoc@48
PS1, Line 48: == Optimizations and improvements
I might also doc that the built-in client is now fully supported (i.e. not experimental), and that --time_source should be used to switch between it and the existing system source.
http://gerrit.cloudera.org:8080/#/c/15456/1/docs/release_notes.adoc@49
PS1, Line 49: `chronyd` of version 3.4 and newer
Nit: `chronyd` (version 3.4 and newer) is now supported...
http://gerrit.cloudera.org:8080/#/c/15456/1/docs/release_notes.adoc@50
PS1, Line 50: In other words,
: with contemporary Linux distributions it's no longer necessary to replace
: `chronyd` with `ntpd` when running Kudu.
I don't think we need to say this.
--
To view, visit http://gerrit.cloudera.org:8080/15456
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I70c2075c73693cc9605372ea5b58044ebbf93bdf
Gerrit-Change-Number: 15456
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 17 Mar 2020 05:08:08 +0000
Gerrit-HasComments: Yes