You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Brian Spindler <da...@gmail.com> on 2013/03/25 00:01:13 UTC

Review Request: Bugfix CLOUDSTACK-1736: Ubuntu 12.04 cloud-setup-management Failed to configure CloudStack Management Server

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10104/
-----------------------------------------------------------

Review request for cloudstack.


Description
-------

Update for CLOUDSTACK-1736. The newly created package for cloudstack-management was not correctly installing the service. This prevented cloud-setup-management from being able to configure the service, and the init script didn't even believe the service was installed. I also added sudo to the chmod command for checking script permissions, as most scripts belong to root.


This addresses bug CLOUDSTACK-1736.


Diffs
-----

  debian/cloudstack-management.install cecc311 
  debian/cloudstack-management.postinst 7b6a1ed 
  debian/rules 613d76a 
  packaging/debian/init/cloud-management 490bf1e 
  packaging/debian/replace.properties fee1def 
  server/src/com/cloud/server/ConfigurationServerImpl.java 3b0ec0f 

Diff: https://reviews.apache.org/r/10104/diff/


Testing
-------

Did a full compile and build of all debs. Installed debs on an Ubuntu 12.04 box, ran cloud-setup-management, and was able to successfully login to the gui.


Thanks,

Brian Spindler


Re: Review Request: Bugfix CLOUDSTACK-1736: Ubuntu 12.04 cloud-setup-management Failed to configure CloudStack Management Server

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10104/#review18344
-----------------------------------------------------------


Commit ae3a04835096f3e2f8dd659a33ac46348e46b670 in branch refs/heads/master from Chip Childers <ch...@gmail.com>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=ae3a048 ]

CLOUDSTACK-1736: Changes required to get cloudstack-management service
working again.

The newly created package for cloudstack-management was not correctly
installing the service. This prevented cloud-setup-management from being
able to configure the service, and the init script didn't even believe
the service was installed. I also added sudo to the chmod command for
checking script permissions, as most scripts belong to root. It was
trying to configure the agent with cloudstack-setup-agent but the script
was still called cloud-setup-agent, so I renamed it to cloudstack-setup-agent.


- ASF Subversion and Git Services


On March 25, 2013, 5:16 p.m., Brian Spindler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10104/
> -----------------------------------------------------------
> 
> (Updated March 25, 2013, 5:16 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> Update for CLOUDSTACK-1736. The newly created package for cloudstack-management was not correctly installing the service. This prevented cloud-setup-management from being able to configure the service, and the init script didn't even believe the service was installed. I also added sudo to the chmod command for checking script permissions, as most scripts belong to root.
> 
> 
> This addresses bug CLOUDSTACK-1736.
> 
> 
> Diffs
> -----
> 
>   debian/cloudstack-agent.install b142571 
>   debian/cloudstack-management.install cecc311 
>   debian/cloudstack-management.postinst 7b6a1ed 
>   debian/rules 613d76a 
>   packaging/debian/init/cloud-management 490bf1e 
>   packaging/debian/replace.properties fee1def 
>   server/src/com/cloud/server/ConfigurationServerImpl.java 3b0ec0f 
> 
> Diff: https://reviews.apache.org/r/10104/diff/
> 
> 
> Testing
> -------
> 
> Did a full compile and build of all debs. Installed debs on an Ubuntu 12.04 box, ran cloud-setup-management, and was able to successfully login to the gui.
> 
> 
> Thanks,
> 
> Brian Spindler
> 
>


Re: Review Request: Bugfix CLOUDSTACK-1736: Ubuntu 12.04 cloud-setup-management Failed to configure CloudStack Management Server

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10104/#review18347
-----------------------------------------------------------


Commit 4d853d7d41a13996eeb6772cae173a672fb792ac in branch refs/heads/4.1 from Chip Childers <ch...@gmail.com>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4d853d7 ]

CLOUDSTACK-1736: Changes required to get cloudstack-management service
working again.

The newly created package for cloudstack-management was not correctly
installing the service. This prevented cloud-setup-management from being
able to configure the service, and the init script didn't even believe
the service was installed. I also added sudo to the chmod command for
checking script permissions, as most scripts belong to root. It was
trying to configure the agent with cloudstack-setup-agent but the script
was still called cloud-setup-agent, so I renamed it to cloudstack-setup-agent.


- ASF Subversion and Git Services


On March 25, 2013, 5:16 p.m., Brian Spindler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10104/
> -----------------------------------------------------------
> 
> (Updated March 25, 2013, 5:16 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> Update for CLOUDSTACK-1736. The newly created package for cloudstack-management was not correctly installing the service. This prevented cloud-setup-management from being able to configure the service, and the init script didn't even believe the service was installed. I also added sudo to the chmod command for checking script permissions, as most scripts belong to root.
> 
> 
> This addresses bug CLOUDSTACK-1736.
> 
> 
> Diffs
> -----
> 
>   debian/cloudstack-agent.install b142571 
>   debian/cloudstack-management.install cecc311 
>   debian/cloudstack-management.postinst 7b6a1ed 
>   debian/rules 613d76a 
>   packaging/debian/init/cloud-management 490bf1e 
>   packaging/debian/replace.properties fee1def 
>   server/src/com/cloud/server/ConfigurationServerImpl.java 3b0ec0f 
> 
> Diff: https://reviews.apache.org/r/10104/diff/
> 
> 
> Testing
> -------
> 
> Did a full compile and build of all debs. Installed debs on an Ubuntu 12.04 box, ran cloud-setup-management, and was able to successfully login to the gui.
> 
> 
> Thanks,
> 
> Brian Spindler
> 
>


Re: Review Request: Bugfix CLOUDSTACK-1736: Ubuntu 12.04 cloud-setup-management Failed to configure CloudStack Management Server

Posted by Chip Childers <ch...@sungard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10104/#review18349
-----------------------------------------------------------

Ship it!


applied to master and 4.1

- Chip Childers


On March 25, 2013, 5:16 p.m., Brian Spindler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10104/
> -----------------------------------------------------------
> 
> (Updated March 25, 2013, 5:16 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> Update for CLOUDSTACK-1736. The newly created package for cloudstack-management was not correctly installing the service. This prevented cloud-setup-management from being able to configure the service, and the init script didn't even believe the service was installed. I also added sudo to the chmod command for checking script permissions, as most scripts belong to root.
> 
> 
> This addresses bug CLOUDSTACK-1736.
> 
> 
> Diffs
> -----
> 
>   debian/cloudstack-agent.install b142571 
>   debian/cloudstack-management.install cecc311 
>   debian/cloudstack-management.postinst 7b6a1ed 
>   debian/rules 613d76a 
>   packaging/debian/init/cloud-management 490bf1e 
>   packaging/debian/replace.properties fee1def 
>   server/src/com/cloud/server/ConfigurationServerImpl.java 3b0ec0f 
> 
> Diff: https://reviews.apache.org/r/10104/diff/
> 
> 
> Testing
> -------
> 
> Did a full compile and build of all debs. Installed debs on an Ubuntu 12.04 box, ran cloud-setup-management, and was able to successfully login to the gui.
> 
> 
> Thanks,
> 
> Brian Spindler
> 
>


Re: Review Request: Bugfix CLOUDSTACK-1736: Ubuntu 12.04 cloud-setup-management Failed to configure CloudStack Management Server

Posted by Brian Spindler <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10104/
-----------------------------------------------------------

(Updated March 25, 2013, 5:16 p.m.)


Review request for cloudstack.


Changes
-------

Updated patch to include some things I missed.


Description
-------

Update for CLOUDSTACK-1736. The newly created package for cloudstack-management was not correctly installing the service. This prevented cloud-setup-management from being able to configure the service, and the init script didn't even believe the service was installed. I also added sudo to the chmod command for checking script permissions, as most scripts belong to root.


This addresses bug CLOUDSTACK-1736.


Diffs (updated)
-----

  debian/cloudstack-agent.install b142571 
  debian/cloudstack-management.install cecc311 
  debian/cloudstack-management.postinst 7b6a1ed 
  debian/rules 613d76a 
  packaging/debian/init/cloud-management 490bf1e 
  packaging/debian/replace.properties fee1def 
  server/src/com/cloud/server/ConfigurationServerImpl.java 3b0ec0f 

Diff: https://reviews.apache.org/r/10104/diff/


Testing
-------

Did a full compile and build of all debs. Installed debs on an Ubuntu 12.04 box, ran cloud-setup-management, and was able to successfully login to the gui.


Thanks,

Brian Spindler