You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/10/29 02:31:21 UTC

[GitHub] [kafka] socutes commented on pull request #11207: KAFKA-10900: Add metrics enumerated in KIP-630

socutes commented on pull request #11207:
URL: https://github.com/apache/kafka/pull/11207#issuecomment-954360311


   > @socutes thanks for the PR. This looks good but I think we should add unit tests in `QuorumControllerTest` for `SnapshotLagSize` and `SnapshotSizeBytesSize`. The histogram metrics may be trickier to test but I think it's worth either coming up with a way to test that or coming up with a solid argument for why the code here is correct.
   
   Thank you for your advice. This PR needs to deal with conflicts first, and I will try to supplement the test cases


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org