You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by sunjincheng121 <gi...@git.apache.org> on 2017/05/19 10:26:02 UTC

[GitHub] flink pull request #3944: [FLINK-6632][table]Improved the method BoolLiteral...

GitHub user sunjincheng121 opened a pull request:

    https://github.com/apache/flink/pull/3944

    [FLINK-6632][table]Improved the method BoolLiteral of ExpressionParse…

    This PR. only improved the method `BoolLiteral` of `ExpressionParser` for case insensitive.
    
    - [x] General
      - The pull request references the related JIRA issue ("[FLINK-6632][table]Improved the method BoolLiteral of ExpressionParser for case insensitive.")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [x] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sunjincheng121/flink FLINK-6632-PR

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3944.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3944
    
----
commit 959af858fb0345c8d28254a3984d58a39e0405c6
Author: sunjincheng121 <su...@gmail.com>
Date:   2017-05-19T10:24:09Z

    [FLINK-6632][table]Improved the method BoolLiteral of ExpressionParser for case insensitive.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3944: [FLINK-6632][table]Improved the method BoolLiteral of Exp...

Posted by sunjincheng121 <gi...@git.apache.org>.

Github user sunjincheng121 commented on the issue:

    https://github.com/apache/flink/pull/3944
  
    Hi, @twalthr In this PR. I want change the method `boolLiteral` of `ExpressionParser`. @fhueske had a suggestion that we should add "true" and "false" as keywords to the parser. Because Keywords are parsed case-insensitive. And I appreciate If you can give us some suggestions.
    
    Thanks,
    SunJincheng


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3944: [FLINK-6632][table]Improved the method BoolLiteral of Exp...

Posted by twalthr <gi...@git.apache.org>.

Github user twalthr commented on the issue:

    https://github.com/apache/flink/pull/3944
  
    Thanks @sunjincheng121. Yes, I think a keyword is a nicer approach. I will add it and merge your tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #3944: [FLINK-6632][table]Improved the method BoolLiteral...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/3944


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---