[GitHub] [doris] HappenLee commented on a diff in pull request #13397: [improvement](scan) speed up inserting strings into ColumnString

[GitBox <gi...@apache.org>]

HappenLee commented on code in PR #13397:
URL: https://github.com/apache/doris/pull/13397#discussion_r996661974


##########
be/src/vec/columns/predicate_column.h:
##########
@@ -91,13 +91,17 @@ class PredicateColumnType final : public COWHelper<IColumn, PredicateColumnType<
     void insert_string_to_res_column(const uint16_t* sel, size_t sel_size,
                                      vectorized::ColumnString* res_ptr) {
         StringRef refs[sel_size];
+        size_t length = 0;
         for (size_t i = 0; i < sel_size; i++) {
             uint16_t n = sel[i];
             auto& sv = reinterpret_cast<StringValue&>(data[n]);
             refs[i].data = sv.ptr;
             refs[i].size = sv.len;
+            length += sv.len;
         }
-        res_ptr->insert_many_continuous_strings(refs, sel_size);

Review Comment:
   only here to call `insert_many_continuous_strings` after delete the code, we should del the funciton



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org