You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by bu...@apache.org on 2004/01/13 00:34:37 UTC
DO NOT REPLY [Bug 26077] New: - Checkstyle reports -Licenses incorrect

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26077>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26077

Checkstyle reports -Licenses incorrect

           Summary: Checkstyle reports -Licenses incorrect
           Product: Struts
           Version: Nightly Build
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: Other
         Component: Web Site
        AssignedTo: struts-dev@jakarta.apache.org
        ReportedBy: tomcatlist@tkz.net


When using maven to generate the site, there are a number of errors generated
when doing the header check.  The header check makes sure the correct license is
used at the top of the file.  In many of our source files an older version of
the license was used or there were small variations.  In a couple instances,
Tomcat was mentioned in the license, not struts.  For various reasons, the
license has been corrected on all but 4 files. 

One odd file in the patch is
src/share/org/apache/struts/tiles/ComponentDefinition.java which seems to have
some funky characters in it and gave me errors when I was trying to fix it.  You
might take a closer look at that one before committing it.

Commit the patch and put the LICENSE.CheckStyle file under CVS control to
implement a solution to inconsistent licenses.  The patch file is 600k, so
probably best to save it to disk.

The 4 remaining inconsistent licenses are:
src/share/org/apache/struts/taglib/bean/IncludeTag.java [has some extra text at
the end, should be looked into]

src/share/org/apache/struts/validator/validwhen/ValidWhenLexer.java
src/share/org/apache/struts/validator/validwhen/ValidWhenParser.java
/src/share/org/apache/struts/validator/validwhen/ValidWhenParserTokenTypes.java
[these three have a comment before that and I'm not familiar with ant-lr, just
regular ant so I don't know if it has to be on the first line or not.  I decided
to leave it alone.]

Paul Sundling

---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org