[GitHub] [spark] ueshin commented on a diff in pull request #42283: [SPARK-44433][PYTHON][CONNECT][SS][FOLLOWUP] Terminate listener process with `removeListener` and improvements

["ueshin (via GitHub)" <gi...@apache.org>]

ueshin commented on code in PR #42283:
URL: https://github.com/apache/spark/pull/42283#discussion_r1283804782


##########
core/src/main/scala/org/apache/spark/api/python/StreamingPythonRunner.scala:
##########
@@ -60,9 +69,9 @@ private[spark] class StreamingPythonRunner(func: PythonFunction, connectUrl: Str
     conf.set(PYTHON_USE_DAEMON, false)

Review Comment:
   This is not updated in this PR, but should we set this back to the original value after creating the Python worker?
   As the `conf` is visible from other part, it could affect the behavior.
   
   It can be done in a separate PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org