[GitHub] [hudi] alexeykudinkin commented on a diff in pull request #5266: [HUDI-3834] Fixing performance hits in reading Column Stats Index

[GitBox <gi...@apache.org>]

alexeykudinkin commented on code in PR #5266:
URL: https://github.com/apache/hudi/pull/5266#discussion_r846555002


##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java:
##########
@@ -159,18 +166,34 @@ public static HoodieTableMetaClient reload(HoodieTableMetaClient oldMetaClient)
    */
   private void readObject(java.io.ObjectInputStream in) throws IOException, ClassNotFoundException {
     in.defaultReadObject();
+    String basePathStr = in.readUTF();
+    String metaPathStr = in.readUTF();
+
     fs = null; // will be lazily initialized
+    basePath = new LazyCachingPath(basePathStr);
+    metaPath = new LazyCachingPath(metaPathStr);
   }
 
   private void writeObject(java.io.ObjectOutputStream out) throws IOException {
     out.defaultWriteObject();
+    out.writeBytes(basePath.toString());
+    out.writeBytes(metaPath.toString());
+  }
+
+  /**
+   * Returns base path of the table
+   */
+  public Path getBasePathV2() {
+    return basePath;
   }
 
   /**
    * @return Base path
+   * @deprecated please use {@link #getBasePathV2()}
    */
+  @Deprecated

Review Comment:
   We should slowly rollover all uses of `getBasePath` into `getBasePathV2` and then rename it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org