You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Frank Klein Koerkamp (JIRA)" <ji...@apache.org> on 2010/11/12 16:35:15 UTC

[jira] Created: (WICKET-3164) executeAjaxEvent in WicketTester works although Component is not enabled

executeAjaxEvent in WicketTester works although Component is not enabled
------------------------------------------------------------------------

                 Key: WICKET-3164
                 URL: https://issues.apache.org/jira/browse/WICKET-3164
             Project: Wicket
          Issue Type: Bug
          Components: wicket
    Affects Versions: 1.4.10
            Reporter: Frank Klein Koerkamp


When Component is disabled the executeAjaxEvent still works. Because it's not checking if Component is enabled.
But the event attribute is not rendered to the component if it's disabled.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-3164) executeAjaxEvent in WicketTester works although Component is not enabled

Posted by "Frank Klein Koerkamp (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-3164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12931425#action_12931425 ] 

Frank Klein Koerkamp commented on WICKET-3164:
----------------------------------------------

executeAjaxEvent can be something like

{code}
Component component = getComponentFromLastRenderedPage(componentPath);
TagTester tagTester = tester.getTagById(component.getMarkupId());
Assert.assertNotNull(tagTester.getAttribute("onblur"));
{code}

// other things that are happening in executeAjaxEvent

> executeAjaxEvent in WicketTester works although Component is not enabled
> ------------------------------------------------------------------------
>
>                 Key: WICKET-3164
>                 URL: https://issues.apache.org/jira/browse/WICKET-3164
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.10
>            Reporter: Frank Klein Koerkamp
>
> When Component is disabled the executeAjaxEvent still works. Because it's not checking if Component is enabled.
> But the event attribute is not rendered to the component if it's disabled.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-3164) executeAjaxEvent in WicketTester works although Component is not enabled

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-3164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934252#action_12934252 ] 

Hudson commented on WICKET-3164:
--------------------------------

Integrated in Apache Wicket 1.4.x #281 (See [https://hudson.apache.org/hudson/job/Apache%20Wicket%201.4.x/281/])
    WICKET-3164 executeAjaxEvent in WicketTester works although Component is not enabled

Add additional checks for 'enabled' and 'visible' component before executing WicketTester's #executeAllTimerBehaviors() and #submitAjaxFormSubmitBehavior()


> executeAjaxEvent in WicketTester works although Component is not enabled
> ------------------------------------------------------------------------
>
>                 Key: WICKET-3164
>                 URL: https://issues.apache.org/jira/browse/WICKET-3164
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.10
>            Reporter: Frank Klein Koerkamp
>            Assignee: Martin Grigorov
>             Fix For: 1.4.14, 1.5-M4
>
>
> When Component is disabled the executeAjaxEvent still works. Because it's not checking if Component is enabled.
> But the event attribute is not rendered to the component if it's disabled.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WICKET-3164) executeAjaxEvent in WicketTester works although Component is not enabled

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov resolved WICKET-3164.
-------------------------------------

    Resolution: Fixed

With r1037409 (1.4.x) and r1037411 (trunk) such checks are added also for #executeAllTimerBehaviors() and #submitAjaxFormSubmitBehavior().

> executeAjaxEvent in WicketTester works although Component is not enabled
> ------------------------------------------------------------------------
>
>                 Key: WICKET-3164
>                 URL: https://issues.apache.org/jira/browse/WICKET-3164
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.10
>            Reporter: Frank Klein Koerkamp
>            Assignee: Martin Grigorov
>             Fix For: 1.4.14, 1.5-M4
>
>
> When Component is disabled the executeAjaxEvent still works. Because it's not checking if Component is enabled.
> But the event attribute is not rendered to the component if it's disabled.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (WICKET-3164) executeAjaxEvent in WicketTester works although Component is not enabled

Posted by "Frank Klein Koerkamp (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-3164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12931425#action_12931425 ] 

Frank Klein Koerkamp edited comment on WICKET-3164 at 11/12/10 10:47 AM:
-------------------------------------------------------------------------

executeAjaxEvent can be something like

{code}
Component component = getComponentFromLastRenderedPage(componentPath);
Component component = getComponentFromLastRenderedPage(componentPath);
TagTester tagTester = tester.getTagById(component.getMarkupId());
if(tagTester.getAttribute(event) == null) {
	throw new RuntimeException("component should be enabled to execute ajax event");
}
{code}

// other things that are happening in executeAjaxEvent

      was (Author: fkleinko):
    executeAjaxEvent can be something like

{code}
Component component = getComponentFromLastRenderedPage(componentPath);
TagTester tagTester = tester.getTagById(component.getMarkupId());
Assert.assertNotNull(tagTester.getAttribute("onblur"));
{code}

// other things that are happening in executeAjaxEvent
  
> executeAjaxEvent in WicketTester works although Component is not enabled
> ------------------------------------------------------------------------
>
>                 Key: WICKET-3164
>                 URL: https://issues.apache.org/jira/browse/WICKET-3164
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.10
>            Reporter: Frank Klein Koerkamp
>
> When Component is disabled the executeAjaxEvent still works. Because it's not checking if Component is enabled.
> But the event attribute is not rendered to the component if it's disabled.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-3164) executeAjaxEvent in WicketTester works although Component is not enabled

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-3164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12931935#action_12931935 ] 

Hudson commented on WICKET-3164:
--------------------------------

Integrated in Apache Wicket 1.4.x #266 (See [https://hudson.apache.org/hudson/job/Apache%20Wicket%201.4.x/266/])
    

> executeAjaxEvent in WicketTester works although Component is not enabled
> ------------------------------------------------------------------------
>
>                 Key: WICKET-3164
>                 URL: https://issues.apache.org/jira/browse/WICKET-3164
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.10
>            Reporter: Frank Klein Koerkamp
>            Assignee: Martin Grigorov
>             Fix For: 1.4.14, 1.5-M4
>
>
> When Component is disabled the executeAjaxEvent still works. Because it's not checking if Component is enabled.
> But the event attribute is not rendered to the component if it's disabled.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WICKET-3164) executeAjaxEvent in WicketTester works although Component is not enabled

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov resolved WICKET-3164.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.5-M4
                   1.4.14

Checks added with r1035045 (1.4.x) and r1035041/1035044 in 1.5/trunk

> executeAjaxEvent in WicketTester works although Component is not enabled
> ------------------------------------------------------------------------
>
>                 Key: WICKET-3164
>                 URL: https://issues.apache.org/jira/browse/WICKET-3164
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.10
>            Reporter: Frank Klein Koerkamp
>            Assignee: Martin Grigorov
>             Fix For: 1.4.14, 1.5-M4
>
>
> When Component is disabled the executeAjaxEvent still works. Because it's not checking if Component is enabled.
> But the event attribute is not rendered to the component if it's disabled.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-3164) executeAjaxEvent in WicketTester works although Component is not enabled

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-3164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12931943#action_12931943 ] 

Hudson commented on WICKET-3164:
--------------------------------

Integrated in Apache Wicket 1.5.x #516 (See [https://hudson.apache.org/hudson/job/Apache%20Wicket%201.5.x/516/])
    

> executeAjaxEvent in WicketTester works although Component is not enabled
> ------------------------------------------------------------------------
>
>                 Key: WICKET-3164
>                 URL: https://issues.apache.org/jira/browse/WICKET-3164
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.10
>            Reporter: Frank Klein Koerkamp
>            Assignee: Martin Grigorov
>             Fix For: 1.4.14, 1.5-M4
>
>
> When Component is disabled the executeAjaxEvent still works. Because it's not checking if Component is enabled.
> But the event attribute is not rendered to the component if it's disabled.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-3164) executeAjaxEvent in WicketTester works although Component is not enabled

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-3164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934254#action_12934254 ] 

Hudson commented on WICKET-3164:
--------------------------------

Integrated in Apache Wicket 1.5.x #539 (See [https://hudson.apache.org/hudson/job/Apache%20Wicket%201.5.x/539/])
    WICKET-3164 executeAjaxEvent in WicketTester works although Component is not enabled

Add additional checks for 'enabled' and 'visible' component before executing WicketTester's #executeAllTimerBehaviors() and #submitAjaxFormSubmitBehavior()

merge r1037409 from 1.4.x


> executeAjaxEvent in WicketTester works although Component is not enabled
> ------------------------------------------------------------------------
>
>                 Key: WICKET-3164
>                 URL: https://issues.apache.org/jira/browse/WICKET-3164
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.10
>            Reporter: Frank Klein Koerkamp
>            Assignee: Martin Grigorov
>             Fix For: 1.4.14, 1.5-M4
>
>
> When Component is disabled the executeAjaxEvent still works. Because it's not checking if Component is enabled.
> But the event attribute is not rendered to the component if it's disabled.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (WICKET-3164) executeAjaxEvent in WicketTester works although Component is not enabled

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov reassigned WICKET-3164:
---------------------------------------

    Assignee: Martin Grigorov

> executeAjaxEvent in WicketTester works although Component is not enabled
> ------------------------------------------------------------------------
>
>                 Key: WICKET-3164
>                 URL: https://issues.apache.org/jira/browse/WICKET-3164
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.10
>            Reporter: Frank Klein Koerkamp
>            Assignee: Martin Grigorov
>
> When Component is disabled the executeAjaxEvent still works. Because it's not checking if Component is enabled.
> But the event attribute is not rendered to the component if it's disabled.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (WICKET-3164) executeAjaxEvent in WicketTester works although Component is not enabled

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov reopened WICKET-3164:
-------------------------------------


I'd like to add checks in all "action" methods.

> executeAjaxEvent in WicketTester works although Component is not enabled
> ------------------------------------------------------------------------
>
>                 Key: WICKET-3164
>                 URL: https://issues.apache.org/jira/browse/WICKET-3164
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.10
>            Reporter: Frank Klein Koerkamp
>            Assignee: Martin Grigorov
>             Fix For: 1.4.14, 1.5-M4
>
>
> When Component is disabled the executeAjaxEvent still works. Because it's not checking if Component is enabled.
> But the event attribute is not rendered to the component if it's disabled.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.