You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Mark Miller (JIRA)" <ji...@apache.org> on 2008/08/29 14:45:44 UTC
[jira] Created: (SOLR-739) Add support for OmitTf
Add support for OmitTf
----------------------
Key: SOLR-739
URL: https://issues.apache.org/jira/browse/SOLR-739
Project: Solr
Issue Type: New Feature
Reporter: Mark Miller
Priority: Minor
Fix For: 1.4
Allow setting omitTf in the field schema. Default to true for all but text fields.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-739) Add support for OmitTf
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631877#action_12631877 ]
Yonik Seeley commented on SOLR-739:
-----------------------------------
OK, so do we have any consensus on what people think is the right approach here?
Upping the schema version to 1.2 doesn't seem like a bad idea.
We could even change the default for omitNorms in 1.2 also....
> Add support for OmitTf
> ----------------------
>
> Key: SOLR-739
> URL: https://issues.apache.org/jira/browse/SOLR-739
> Project: Solr
> Issue Type: New Feature
> Reporter: Mark Miller
> Priority: Minor
> Fix For: 1.4
>
> Attachments: SOLR-739.patch
>
>
> Allow setting omitTf in the field schema. Default to true for all but text fields.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SOLR-739) Add support for OmitTf
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yonik Seeley resolved SOLR-739.
-------------------------------
Resolution: Fixed
Committed. Thanks Mark!
> Add support for OmitTf
> ----------------------
>
> Key: SOLR-739
> URL: https://issues.apache.org/jira/browse/SOLR-739
> Project: Solr
> Issue Type: New Feature
> Reporter: Mark Miller
> Priority: Minor
> Fix For: 1.4
>
> Attachments: SOLR-739.patch, SOLR-739.patch
>
>
> Allow setting omitTf in the field schema. Default to true for all but text fields.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-739) Add support for OmitTf
Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631890#action_12631890 ]
Hoss Man commented on SOLR-739:
-------------------------------
the other possibility would be to make it FieldType specific ... leave tf in by default, but make classes where there's a 90% chance it's not need (SortableIntField, DateField, etc...) override a method disabling it.
> Add support for OmitTf
> ----------------------
>
> Key: SOLR-739
> URL: https://issues.apache.org/jira/browse/SOLR-739
> Project: Solr
> Issue Type: New Feature
> Reporter: Mark Miller
> Priority: Minor
> Fix For: 1.4
>
> Attachments: SOLR-739.patch
>
>
> Allow setting omitTf in the field schema. Default to true for all but text fields.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-739) Add support for OmitTf
Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12675773#action_12675773 ]
Shalin Shekhar Mangar commented on SOLR-739:
--------------------------------------------
Can someone add a little more documentation on how it helps or when should one change the default on the wiki and example schema file?
> Add support for OmitTf
> ----------------------
>
> Key: SOLR-739
> URL: https://issues.apache.org/jira/browse/SOLR-739
> Project: Solr
> Issue Type: New Feature
> Reporter: Mark Miller
> Priority: Minor
> Fix For: 1.4
>
> Attachments: SOLR-739.patch, SOLR-739.patch
>
>
> Allow setting omitTf in the field schema. Default to true for all but text fields.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-739) Add support for OmitTf
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12637612#action_12637612 ]
Mark Miller commented on SOLR-739:
----------------------------------
So whats the verdict...leave as is, or should I tick the schema version?
> Add support for OmitTf
> ----------------------
>
> Key: SOLR-739
> URL: https://issues.apache.org/jira/browse/SOLR-739
> Project: Solr
> Issue Type: New Feature
> Reporter: Mark Miller
> Priority: Minor
> Fix For: 1.4
>
> Attachments: SOLR-739.patch
>
>
> Allow setting omitTf in the field schema. Default to true for all but text fields.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-739) Add support for OmitTf
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627057#action_12627057 ]
Yonik Seeley commented on SOLR-739:
-----------------------------------
I think it's unlikely to matter for non-text fields, but I guess we could always change the default to "false" and then update the example schema to set it to "true" everywhere except text fields.
> Add support for OmitTf
> ----------------------
>
> Key: SOLR-739
> URL: https://issues.apache.org/jira/browse/SOLR-739
> Project: Solr
> Issue Type: New Feature
> Reporter: Mark Miller
> Priority: Minor
> Fix For: 1.4
>
> Attachments: SOLR-739.patch
>
>
> Allow setting omitTf in the field schema. Default to true for all but text fields.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-739) Add support for OmitTf
Posted by "Mike Klaas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627049#action_12627049 ]
Mike Klaas commented on SOLR-739:
---------------------------------
Haven't looked at the patch, but defaulting to omitTf=true is backwards-incompatible (think multi-valued string fields)
> Add support for OmitTf
> ----------------------
>
> Key: SOLR-739
> URL: https://issues.apache.org/jira/browse/SOLR-739
> Project: Solr
> Issue Type: New Feature
> Reporter: Mark Miller
> Priority: Minor
> Fix For: 1.4
>
> Attachments: SOLR-739.patch
>
>
> Allow setting omitTf in the field schema. Default to true for all but text fields.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-739) Add support for OmitTf
Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627129#action_12627129 ]
Hoss Man commented on SOLR-739:
-------------------------------
FWIW: this is a situation where reving the schema version could make sense as well (just as we did when adding multiValued, we want the default ot change but not forr existing users)
> Add support for OmitTf
> ----------------------
>
> Key: SOLR-739
> URL: https://issues.apache.org/jira/browse/SOLR-739
> Project: Solr
> Issue Type: New Feature
> Reporter: Mark Miller
> Priority: Minor
> Fix For: 1.4
>
> Attachments: SOLR-739.patch
>
>
> Allow setting omitTf in the field schema. Default to true for all but text fields.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-739) Add support for OmitTf
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631904#action_12631904 ]
Yonik Seeley commented on SOLR-739:
-----------------------------------
bq. the other possibility would be to make it FieldType specific ... leave tf in by default, but make classes where there's a 90% chance it's not need (SortableIntField, DateField, etc...) override a method disabling it.
That's essentially what is done in the current patch... it defaults to ommitted and TextField changes it's default to include tf.
> Add support for OmitTf
> ----------------------
>
> Key: SOLR-739
> URL: https://issues.apache.org/jira/browse/SOLR-739
> Project: Solr
> Issue Type: New Feature
> Reporter: Mark Miller
> Priority: Minor
> Fix For: 1.4
>
> Attachments: SOLR-739.patch
>
>
> Allow setting omitTf in the field schema. Default to true for all but text fields.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-739) Add support for OmitTf
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12675882#action_12675882 ]
Mark Miller commented on SOLR-739:
----------------------------------
Good point, will do.
- Mark
> Add support for OmitTf
> ----------------------
>
> Key: SOLR-739
> URL: https://issues.apache.org/jira/browse/SOLR-739
> Project: Solr
> Issue Type: New Feature
> Reporter: Mark Miller
> Priority: Minor
> Fix For: 1.4
>
> Attachments: SOLR-739.patch, SOLR-739.patch
>
>
> Allow setting omitTf in the field schema. Default to true for all but text fields.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-739) Add support for OmitTf
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Miller updated SOLR-739:
-----------------------------
Attachment: SOLR-739.patch
Simple patch, but my first look at Schema stuff so merits a bit of scrutiny.
> Add support for OmitTf
> ----------------------
>
> Key: SOLR-739
> URL: https://issues.apache.org/jira/browse/SOLR-739
> Project: Solr
> Issue Type: New Feature
> Reporter: Mark Miller
> Priority: Minor
> Fix For: 1.4
>
> Attachments: SOLR-739.patch
>
>
> Allow setting omitTf in the field schema. Default to true for all but text fields.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-739) Add support for OmitTf
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Miller updated SOLR-739:
-----------------------------
Attachment: SOLR-739.patch
Updated to trunk
Ticks schema version to 1.2, >=1.2 defaults to omitTf except for TextField.
> Add support for OmitTf
> ----------------------
>
> Key: SOLR-739
> URL: https://issues.apache.org/jira/browse/SOLR-739
> Project: Solr
> Issue Type: New Feature
> Reporter: Mark Miller
> Priority: Minor
> Fix For: 1.4
>
> Attachments: SOLR-739.patch, SOLR-739.patch
>
>
> Allow setting omitTf in the field schema. Default to true for all but text fields.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.