[GitHub] pnowojski commented on a change in pull request #6963: [FLINK-10704] Fix sql client end to end test failure

[GitBox <gi...@apache.org>]

pnowojski commented on a change in pull request #6963: [FLINK-10704] Fix sql client end to end test failure
URL: https://github.com/apache/flink/pull/6963#discussion_r229610938
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/common.sh
 ##########
 @@ -316,7 +316,7 @@ function check_logs_for_errors {
       | grep -v "java.lang.NoClassDefFoundError: org/apache/hadoop/yarn/exceptions/YarnException" \
       | grep -v "java.lang.NoClassDefFoundError: org/apache/hadoop/conf/Configuration" \
       | grep -v "org.apache.flink.fs.shaded.hadoop3.org.apache.commons.beanutils.FluentPropertyBeanIntrospector  - Error when creating PropertyDescriptor for public final void org.apache.flink.fs.shaded.hadoop3.org.apache.commons.configuration2.AbstractConfiguration.setProperty(java.lang.String,java.lang.Object)! Ignoring this property." \
-      | grep -ic "error")
+      | grep -c "ERROR")
 
 Review comment:
   As I have written in the ticket:
   
   > This global `check_logs_for_errors ` is broken design. We might want to have some limited global list of exclusions, but adding more entries to ever growing list is unmaintainable. I think we should filter out this one specific warning in kafka tests and do not mess with changing global rules for all of the tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services