[jira] [Commented] (DOXIA-670) Drop dead XdocSink#link(String, String) method

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DOXIA-670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17611963#comment-17611963 ] 

ASF GitHub Bot commented on DOXIA-670:
--------------------------------------

michael-o commented on code in PR #116:
URL: https://github.com/apache/maven-doxia/pull/116#discussion_r985129510


##########
doxia-modules/doxia-module-xdoc/src/main/java/org/apache/maven/doxia/module/xdoc/XdocSink.java:
##########
@@ -505,31 +497,6 @@ public void close()
         init();
     }
 
-    /**
-     * Adds a link with an optional target.
-     *
-     * @param name the link name.
-     * @param target the link target, may be null.
-     */
-    public void link( String name, String target )
-    {
-        if ( isHeadFlag() )
-        {
-            return;
-        }
-
-        MutableAttributeSet att = new SinkEventAttributeSet();
-
-        att.addAttribute( Attribute.HREF, HtmlTools.escapeHTML( name ) );
-
-        if ( target != null )
-        {
-            att.addAttribute( Attribute.TARGET, target );
-        }
-
-        writeStartTag( A, att );
-    }
-

Review Comment:
   @hboutemy Done, completely reduced. Attributes are in another ticket. As for the `source`. HTML5 has now a source element which collides with Xdoc's source. That is why I decided not to fiddle with at the moment. Forget about it.





> Drop dead XdocSink#link(String, String) method
> ----------------------------------------------
>
>                 Key: DOXIA-670
>                 URL: https://issues.apache.org/jira/browse/DOXIA-670
>             Project: Maven Doxia
>          Issue Type: Task
>          Components: Module - Xhtml
>    Affects Versions: 2.0.0-M3
>            Reporter: Michael Osipov
>            Assignee: Michael Osipov
>            Priority: Major
>             Fix For: 2.0.0-M4
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)