You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/11/08 07:40:41 UTC

[GitHub] [incubator-superset] john-bodley opened a new pull request #8531: [docs] Adding Slice parameter documentation

john-bodley opened a new pull request #8531: [docs] Adding Slice parameter documentation
URL: https://github.com/apache/incubator-superset/pull/8531
 
 
   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [x] Documentation
   
   ### SUMMARY
   
   I'm working on a project to migrate charts using the Druid native JSON-based query API to Druid SQL and wanted to determine which of the slice parameters aka form-data fields needed to be modified. 
   
   Given that the JSON form-data currently doesn't have schema validation nor is typed (not in the future I sense it should be) I simply ran a query to fetch all the fields which exist in our deployment and felt these should be documented as an interim form of record keeping. 
   
   Granted Markdown isn't probably the best document form to tabularize these fields (a spreadsheet is probably preferred) but I felt having this information reside in the repo is probably preferred. 
   
   Per the comments in the doc some of these fields may be deprecated and others are not categorized but I sense it's a least a start. 
   
   ### TEST PLAN
   
   N/A
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   
   to: @betodealmeida @etr2460 @mistercrunch @villebro @willbarrett 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org