You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/10/08 14:50:48 UTC
[GitHub] [ignite-extensions] ololo3000 opened a new pull request #25: IGNITE-13599 Migrates spring-data modules to ignite-extensions.
ololo3000 opened a new pull request #25:
URL: https://github.com/apache/ignite-extensions/pull/25
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-extensions] samaitra commented on a change in pull request #25: IGNITE-13599 Migrates spring-data modules to ignite-extensions.
Posted by GitBox <gi...@apache.org>.
samaitra commented on a change in pull request #25:
URL: https://github.com/apache/ignite-extensions/pull/25#discussion_r502741476
##########
File path: modules/spring-data-2.2/README.txt
##########
@@ -0,0 +1,47 @@
+Apache Ignite Spring Module
Review comment:
we can rename the folder name to spring-data-2.2-ext
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-extensions] samaitra commented on pull request #25: IGNITE-13599 Migrates spring-data modules to ignite-extensions.
Posted by GitBox <gi...@apache.org>.
samaitra commented on pull request #25:
URL: https://github.com/apache/ignite-extensions/pull/25#issuecomment-706483514
Also once the changes are complete please add modules details and Testsuites in the teamcity build config https://ci.ignite.apache.org/admin/editBuildParams.html?id=buildType:Tests_IgniteExtensions_Build
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-extensions] ololo3000 commented on pull request #25: IGNITE-13599 Migrates spring-data modules to ignite-extensions.
Posted by GitBox <gi...@apache.org>.
ololo3000 commented on pull request #25:
URL: https://github.com/apache/ignite-extensions/pull/25#issuecomment-706529451
@samaitra Thanks a lot for the review. I fixed all mentioned by you comments. Could you, please, take a look?
I don't have enough permissions to edit TC build config. How can I obtain them?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-extensions] samaitra commented on a change in pull request #25: IGNITE-13599 Migrates spring-data modules to ignite-extensions.
Posted by GitBox <gi...@apache.org>.
samaitra commented on a change in pull request #25:
URL: https://github.com/apache/ignite-extensions/pull/25#discussion_r502742224
##########
File path: modules/spring-data/README.txt
##########
@@ -0,0 +1,32 @@
+Apache Ignite Spring Module
+---------------------------
+
+Apache Ignite Spring Data module provides an integration with Spring Data framework.
+
+To enable Spring Data module when starting a standalone node, move 'optional/ignite-spring-data' folder to
+'libs' folder before running 'ignite.{sh|bat}' script. The content of the module folder will
+be added to classpath in this case.
+
+Importing Spring Data Module In Maven Project
+----------------------------------------
+
+If you are using Maven to manage dependencies of your project, you can add Spring module
+dependency like this (replace '${ignite.version}' with actual Ignite version you are
+interested in):
+
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
+ http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ ...
+ <dependencies>
+ ...
+ <dependency>
+ <groupId>org.apache.ignite</groupId>
+ <artifactId>ignite-spring-data</artifactId>
+ <version>${ignite.version}</version>
Review comment:
The version for the module would be `${ignite-spring-data-ext.version}`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-extensions] samaitra commented on a change in pull request #25: IGNITE-13599 Migrates spring-data modules to ignite-extensions.
Posted by GitBox <gi...@apache.org>.
samaitra commented on a change in pull request #25:
URL: https://github.com/apache/ignite-extensions/pull/25#discussion_r502741784
##########
File path: modules/spring-data-2.2/pom.xml
##########
@@ -0,0 +1,154 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+
+<!--
+ POM file.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.apache.ignite</groupId>
+ <artifactId>ignite-extensions-parent</artifactId>
+ <version>1</version>
+ <relativePath>../../parent</relativePath>
+ </parent>
+
+ <artifactId>ignite-spring-data_2.2</artifactId>
Review comment:
We can rename the artifactId to ignite-spring-data_2.2-ext
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-extensions] samaitra commented on a change in pull request #25: IGNITE-13599 Migrates spring-data modules to ignite-extensions.
Posted by GitBox <gi...@apache.org>.
samaitra commented on a change in pull request #25:
URL: https://github.com/apache/ignite-extensions/pull/25#discussion_r502741735
##########
File path: modules/spring-data-2.2/README.txt
##########
@@ -0,0 +1,47 @@
+Apache Ignite Spring Module
+---------------------------
+
+Apache Ignite Spring Data 2.2 module provides an integration with Spring Data 2.2 framework.
+
+To enable Spring Data 2.2 module when starting a standalone node, move 'optional/ignite-spring-data' folder to
+'libs' folder before running 'ignite.{sh|bat}' script. The content of the module folder will
+be added to classpath in this case.
+
+Main features:
+
+- Supports multiple Ignite instances on same JVM (@RepositoryConfig).
+- Supports query tuning parameters in @Query annotation
+- Supports projections
+- Supports Page and Stream responses
+- Supports Sql Fields Query resultset transformation into the domain entity
+- Supports named parameters (:myParam) into SQL queries, declared using @Param("myParam")
+- Supports advanced parameter binding and SpEL expressions into SQL queries:
+- Template variables:
+ - #entityName - the simple class name of the domain entity
+- Method parameter expressions: Parameters are exposed for indexed access ([0] is the first query method's param) or via the name declared using @Param. The actual SpEL expression binding is triggered by ?#. Example: ?#{[0] or ?#{#myParamName}
+- Advanced SpEL expressions: While advanced parameter binding is a very useful feature, the real power of SpEL stems from the fact, that the expressions can refer to framework abstractions or other application components through SpEL EvaluationContext extension model.
+- Supports SpEL expressions into Text queries (TextQuery).
+
+Importing Spring Data 2.2 Module In Maven Project
+----------------------------------------
+
+If you are using Maven to manage dependencies of your project, you can add Spring module
+dependency like this (replace '${ignite.version}' with actual Ignite version you are
+interested in):
+
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
+ http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ ...
+ <dependencies>
+ ...
+ <dependency>
+ <groupId>org.apache.ignite</groupId>
+ <artifactId>ignite-spring-data_2.2</artifactId>
+ <version>${ignite.version}</version>
Review comment:
The version here would be `${ignite-spring-data_2.2-ext.version}`. Note that the first release of the module would be `1.0.0` and not ignite version of `2.9.0`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-extensions] samaitra commented on a change in pull request #25: IGNITE-13599 Migrates spring-data modules to ignite-extensions.
Posted by GitBox <gi...@apache.org>.
samaitra commented on a change in pull request #25:
URL: https://github.com/apache/ignite-extensions/pull/25#discussion_r502742529
##########
File path: modules/spring-data-2.0/README.txt
##########
@@ -0,0 +1,47 @@
+Apache Ignite Spring Module
+---------------------------
+
+Apache Ignite Spring Data 2.0 module provides an integration with Spring Data 2.0 framework.
+
+To enable Spring Data 2.0 module when starting a standalone node, move 'optional/ignite-spring-data' folder to
+'libs' folder before running 'ignite.{sh|bat}' script. The content of the module folder will
+be added to classpath in this case.
+
+Main features:
+
+- Supports multiple Ignite instances on same JVM (@RepositoryConfig).
+- Supports query tuning parameters in @Query annotation
+- Supports projections
+- Supports Page and Stream responses
+- Supports Sql Fields Query resultset transformation into the domain entity
+- Supports named parameters (:myParam) into SQL queries, declared using @Param("myParam")
+- Supports advanced parameter binding and SpEL expressions into SQL queries:
+- Template variables:
+ - #entityName - the simple class name of the domain entity
+- Method parameter expressions: Parameters are exposed for indexed access ([0] is the first query method's param) or via the name declared using @Param. The actual SpEL expression binding is triggered by ?#. Example: ?#{[0] or ?#{#myParamName}
+- Advanced SpEL expressions: While advanced parameter binding is a very useful feature, the real power of SpEL stems from the fact, that the expressions can refer to framework abstractions or other application components through SpEL EvaluationContext extension model.
+- Supports SpEL expressions into Text queries (TextQuery).
+
+Importing Spring Data 2.0 Module In Maven Project
+----------------------------------------
+
+If you are using Maven to manage dependencies of your project, you can add Spring module
+dependency like this (replace '${ignite.version}' with actual Ignite version you are
+interested in):
+
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
+ http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ ...
+ <dependencies>
+ ...
+ <dependency>
+ <groupId>org.apache.ignite</groupId>
+ <artifactId>ignite-spring-data_2.0</artifactId>
+ <version>${ignite.version}</version>
Review comment:
The version here would be `${ignite-spring-data_2.0-ext.version}`
##########
File path: modules/spring-data/README.txt
##########
@@ -0,0 +1,32 @@
+Apache Ignite Spring Module
Review comment:
We can rename the folder to spring-data-ext.
##########
File path: modules/spring-data-2.0/README.txt
##########
@@ -0,0 +1,47 @@
+Apache Ignite Spring Module
Review comment:
WE can rename the folder to spring-data-2.0-ext
##########
File path: modules/spring-data-2.0/README.txt
##########
@@ -0,0 +1,47 @@
+Apache Ignite Spring Module
Review comment:
We can rename the folder to spring-data-2.0-ext
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-extensions] samaitra commented on a change in pull request #25: IGNITE-13599 Migrates spring-data modules to ignite-extensions.
Posted by GitBox <gi...@apache.org>.
samaitra commented on a change in pull request #25:
URL: https://github.com/apache/ignite-extensions/pull/25#discussion_r502741978
##########
File path: pom.xml
##########
@@ -55,6 +55,9 @@
<module>modules/camel-ext</module>
<module>modules/jms11-ext</module>
<module>modules/kafka-ext</module>
+ <module>modules/spring-data</module>
+ <module>modules/spring-data-2.0</module>
+ <module>modules/spring-data-2.2</module>
Review comment:
We can rename these modules to `sprint-data-ext`, `spring-data-2.0-ext`and `spring-data-2.2-ext`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-extensions] samaitra commented on a change in pull request #25: IGNITE-13599 Migrates spring-data modules to ignite-extensions.
Posted by GitBox <gi...@apache.org>.
samaitra commented on a change in pull request #25:
URL: https://github.com/apache/ignite-extensions/pull/25#discussion_r502740981
##########
File path: modules/spring-data-2.0/README.txt
##########
@@ -0,0 +1,47 @@
+Apache Ignite Spring Module
+---------------------------
+
+Apache Ignite Spring Data 2.0 module provides an integration with Spring Data 2.0 framework.
+
+To enable Spring Data 2.0 module when starting a standalone node, move 'optional/ignite-spring-data' folder to
+'libs' folder before running 'ignite.{sh|bat}' script. The content of the module folder will
+be added to classpath in this case.
+
+Main features:
+
+- Supports multiple Ignite instances on same JVM (@RepositoryConfig).
+- Supports query tuning parameters in @Query annotation
+- Supports projections
+- Supports Page and Stream responses
+- Supports Sql Fields Query resultset transformation into the domain entity
+- Supports named parameters (:myParam) into SQL queries, declared using @Param("myParam")
+- Supports advanced parameter binding and SpEL expressions into SQL queries:
+- Template variables:
+ - #entityName - the simple class name of the domain entity
+- Method parameter expressions: Parameters are exposed for indexed access ([0] is the first query method's param) or via the name declared using @Param. The actual SpEL expression binding is triggered by ?#. Example: ?#{[0] or ?#{#myParamName}
+- Advanced SpEL expressions: While advanced parameter binding is a very useful feature, the real power of SpEL stems from the fact, that the expressions can refer to framework abstractions or other application components through SpEL EvaluationContext extension model.
+- Supports SpEL expressions into Text queries (TextQuery).
+
+Importing Spring Data 2.0 Module In Maven Project
+----------------------------------------
+
+If you are using Maven to manage dependencies of your project, you can add Spring module
+dependency like this (replace '${ignite.version}' with actual Ignite version you are
+interested in):
+
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
+ http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ ...
+ <dependencies>
+ ...
+ <dependency>
+ <groupId>org.apache.ignite</groupId>
+ <artifactId>ignite-spring-data_2.0</artifactId>
Review comment:
can you please rename the artifactId to ignite-spring-data_2.0-ext so that it is similar to other extensions modules?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-extensions] nizhikov merged pull request #25: IGNITE-13559 Migrates spring-data modules to ignite-extensions.
Posted by GitBox <gi...@apache.org>.
nizhikov merged pull request #25:
URL: https://github.com/apache/ignite-extensions/pull/25
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-extensions] samaitra commented on a change in pull request #25: IGNITE-13599 Migrates spring-data modules to ignite-extensions.
Posted by GitBox <gi...@apache.org>.
samaitra commented on a change in pull request #25:
URL: https://github.com/apache/ignite-extensions/pull/25#discussion_r502741124
##########
File path: modules/spring-data-2.0/pom.xml
##########
@@ -0,0 +1,154 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+
+<!--
+ POM file.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.apache.ignite</groupId>
+ <artifactId>ignite-extensions-parent</artifactId>
+ <version>1</version>
+ <relativePath>../../parent</relativePath>
+ </parent>
+
+ <artifactId>ignite-spring-data_2.0</artifactId>
Review comment:
same here we can rename to ignite-spring-data_2.0-ext.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-extensions] samaitra commented on a change in pull request #25: IGNITE-13599 Migrates spring-data modules to ignite-extensions.
Posted by GitBox <gi...@apache.org>.
samaitra commented on a change in pull request #25:
URL: https://github.com/apache/ignite-extensions/pull/25#discussion_r502741496
##########
File path: modules/spring-data-2.2/README.txt
##########
@@ -0,0 +1,47 @@
+Apache Ignite Spring Module
+---------------------------
+
+Apache Ignite Spring Data 2.2 module provides an integration with Spring Data 2.2 framework.
+
+To enable Spring Data 2.2 module when starting a standalone node, move 'optional/ignite-spring-data' folder to
+'libs' folder before running 'ignite.{sh|bat}' script. The content of the module folder will
+be added to classpath in this case.
+
+Main features:
+
+- Supports multiple Ignite instances on same JVM (@RepositoryConfig).
+- Supports query tuning parameters in @Query annotation
+- Supports projections
+- Supports Page and Stream responses
+- Supports Sql Fields Query resultset transformation into the domain entity
+- Supports named parameters (:myParam) into SQL queries, declared using @Param("myParam")
+- Supports advanced parameter binding and SpEL expressions into SQL queries:
+- Template variables:
+ - #entityName - the simple class name of the domain entity
+- Method parameter expressions: Parameters are exposed for indexed access ([0] is the first query method's param) or via the name declared using @Param. The actual SpEL expression binding is triggered by ?#. Example: ?#{[0] or ?#{#myParamName}
+- Advanced SpEL expressions: While advanced parameter binding is a very useful feature, the real power of SpEL stems from the fact, that the expressions can refer to framework abstractions or other application components through SpEL EvaluationContext extension model.
+- Supports SpEL expressions into Text queries (TextQuery).
+
+Importing Spring Data 2.2 Module In Maven Project
+----------------------------------------
+
+If you are using Maven to manage dependencies of your project, you can add Spring module
+dependency like this (replace '${ignite.version}' with actual Ignite version you are
+interested in):
+
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
+ http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ ...
+ <dependencies>
+ ...
+ <dependency>
+ <groupId>org.apache.ignite</groupId>
+ <artifactId>ignite-spring-data_2.2</artifactId>
Review comment:
we can rename the artifactId to ignite-spring-data_2.2-ext
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-extensions] samaitra commented on a change in pull request #25: IGNITE-13599 Migrates spring-data modules to ignite-extensions.
Posted by GitBox <gi...@apache.org>.
samaitra commented on a change in pull request #25:
URL: https://github.com/apache/ignite-extensions/pull/25#discussion_r502742196
##########
File path: modules/spring-data/README.txt
##########
@@ -0,0 +1,32 @@
+Apache Ignite Spring Module
+---------------------------
+
+Apache Ignite Spring Data module provides an integration with Spring Data framework.
+
+To enable Spring Data module when starting a standalone node, move 'optional/ignite-spring-data' folder to
+'libs' folder before running 'ignite.{sh|bat}' script. The content of the module folder will
+be added to classpath in this case.
+
+Importing Spring Data Module In Maven Project
+----------------------------------------
+
+If you are using Maven to manage dependencies of your project, you can add Spring module
+dependency like this (replace '${ignite.version}' with actual Ignite version you are
+interested in):
+
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
+ http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ ...
+ <dependencies>
+ ...
+ <dependency>
+ <groupId>org.apache.ignite</groupId>
+ <artifactId>ignite-spring-data</artifactId>
Review comment:
We can rename the artifactId to ignite-spring-data-ext
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-extensions] samaitra commented on a change in pull request #25: IGNITE-13599 Migrates spring-data modules to ignite-extensions.
Posted by GitBox <gi...@apache.org>.
samaitra commented on a change in pull request #25:
URL: https://github.com/apache/ignite-extensions/pull/25#discussion_r502742807
##########
File path: modules/spring-data/pom.xml
##########
@@ -0,0 +1,100 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+
+<!--
+ POM file.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.apache.ignite</groupId>
+ <artifactId>ignite-extensions-parent</artifactId>
+ <version>1</version>
+ <relativePath>../../parent</relativePath>
+ </parent>
+
+ <artifactId>ignite-spring-data</artifactId>
Review comment:
We can rename the artifactId to ignite-spring-data-ext
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org