[jira] [Commented] (ARTEMIS-1793) Do not expose the _AMQ_ROUTING_TYPE header (at least) in STOMP

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARTEMIS-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16431133#comment-16431133 ] 

ASF GitHub Bot commented on ARTEMIS-1793:
-----------------------------------------

GitHub user jbertram opened a pull request:

    https://github.com/apache/activemq-artemis/pull/2004

    ARTEMIS-1793 fix 'destination-type' STOMP header

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1793

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/2004.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2004
    
----
commit bffdf1381622e7bb7856b39fb92e90c7c0e5d93b
Author: Justin Bertram <jb...@...>
Date:   2018-04-09T19:39:48Z

    ARTEMIS-1793 fix 'destination-type' STOMP header

----


> Do not expose the _AMQ_ROUTING_TYPE header (at least) in STOMP
> --------------------------------------------------------------
>
>                 Key: ARTEMIS-1793
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1793
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>    Affects Versions: 2.5.0
>            Reporter: Lionel Cons
>            Priority: Minor
>
> Artemis currently exposes the {{_AMQ_ROUTING_TYPE}} at least when using STOMP.
> Here is what a STOMP {{MESSAGE}} frame currently looks like (header part only):
> {code}
> _AMQ_ROUTING_TYPE:1
> content-length:1
> content-type:text/unknown
> destination:whatever
> expires:0
> message-id:123
> persistent:false
> priority:4
> redelivered:false
> timestamp:1523267009887
> {code}
> All the header lines are useful (and with typical lowercase names) except {{_AMQ_ROUTING_TYPE}}.
> If this information can be useful to messaging clients then a more "user friendly" name should be used and documented.
> Otherwise, this header should probably not be exposed, at least not by default.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)