You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "elharo (via GitHub)" <gi...@apache.org> on 2023/10/07 13:33:21 UTC

[PR] [IO-414] don't write a BOM on every (or any) line [commons-io]

elharo opened a new pull request, #492:
URL: https://github.com/apache/commons-io/pull/492

   Per JDK docs, "When decoding, the UTF-16 charset interprets the byte-order mark at the beginning of the input stream to indicate the byte-order of the stream but defaults to big-endian if there is no byte-order mark; when encoding, it uses big-endian byte order and writes a big-endian byte-order mark."


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [IO-414] don't write a BOM on every (or any) line [commons-io]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #492:
URL: https://github.com/apache/commons-io/pull/492#issuecomment-1751716351

   ## [Codecov](https://app.codecov.io/gh/apache/commons-io/pull/492?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#492](https://app.codecov.io/gh/apache/commons-io/pull/492?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (adb2f49) into [master](https://app.codecov.io/gh/apache/commons-io/commit/877b9e3f5e553f8ad988b89b8adb6b93fa97a964?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (877b9e3) will **decrease** coverage by `0.01%`.
   > The diff coverage is `100.00%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #492      +/-   ##
   ============================================
   - Coverage     84.97%   84.96%   -0.01%     
     Complexity     3372     3372              
   ============================================
     Files           227      227              
     Lines          8080     8082       +2     
     Branches        953      954       +1     
   ============================================
   + Hits           6866     6867       +1     
     Misses          960      960              
   - Partials        254      255       +1     
   ```
   
   
   | [Files](https://app.codecov.io/gh/apache/commons-io/pull/492?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [src/main/java/org/apache/commons/io/IOUtils.java](https://app.codecov.io/gh/apache/commons-io/pull/492?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvaW8vSU9VdGlscy5qYXZh) | `86.81% <100.00%> (+0.04%)` | :arrow_up: |
   
   ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/apache/commons-io/pull/492/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [IO-414] don't write a BOM on every (or any) line [commons-io]

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory merged PR #492:
URL: https://github.com/apache/commons-io/pull/492


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org