You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/01/08 17:27:28 UTC

[GitHub] kristw closed pull request #6271: fix(i18n) syntax errors detected by grammarly while translating

kristw closed pull request #6271: fix(i18n) syntax errors detected by grammarly while translating
URL: https://github.com/apache/incubator-superset/pull/6271
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/assets/backendSync.json b/superset/assets/backendSync.json
index 711496dcd3..1f85b01da2 100644
--- a/superset/assets/backendSync.json
+++ b/superset/assets/backendSync.json
@@ -2194,7 +2194,7 @@
       "label": "Search Box",
       "renderTrigger": true,
       "default": false,
-      "description": "Whether to include a client side search box"
+      "description": "Whether to include a client-side search box"
     },
     "table_filter": {
       "type": "CheckboxControl",
@@ -2534,7 +2534,7 @@
       "type": "CheckboxControl",
       "label": "Live render",
       "default": true,
-      "description": "Points and clusters will update as viewport is being changed"
+      "description": "Points and clusters will update as the viewport is being changed"
     },
     "mapbox_color": {
       "type": "SelectControl",
diff --git a/superset/assets/src/explore/controls.jsx b/superset/assets/src/explore/controls.jsx
index 92dfb1c24a..4e8773d1cd 100644
--- a/superset/assets/src/explore/controls.jsx
+++ b/superset/assets/src/explore/controls.jsx
@@ -1439,7 +1439,7 @@ export const controls = {
     label: t('Search Box'),
     renderTrigger: true,
     default: false,
-    description: t('Whether to include a client side search box'),
+    description: t('Whether to include a client-side search box'),
   },
 
   table_filter: {
@@ -1842,7 +1842,7 @@ export const controls = {
     type: 'CheckboxControl',
     label: t('Live render'),
     default: true,
-    description: t('Points and clusters will update as viewport is being changed'),
+    description: t('Points and clusters will update as the viewport is being changed'),
   },
 
   mapbox_color: {
diff --git a/superset/connectors/sqla/views.py b/superset/connectors/sqla/views.py
index c085958f5b..d8293ac543 100644
--- a/superset/connectors/sqla/views.py
+++ b/superset/connectors/sqla/views.py
@@ -270,7 +270,7 @@ def post_add(self, table, flash_message=True):
         if flash_message:
             flash(_(
                 'The table was created. '
-                'As part of this two phase configuration '
+                'As part of this two-phase configuration '
                 'process, you should now click the edit button by '
                 'the new table to configure it.'), 'info')
 
diff --git a/superset/views/core.py b/superset/views/core.py
index 2af85148c2..c22c585a20 100755
--- a/superset/views/core.py
+++ b/superset/views/core.py
@@ -60,7 +60,7 @@
 
 ALL_DATASOURCE_ACCESS_ERR = __(
     'This endpoint requires the `all_datasource_access` permission')
-DATASOURCE_MISSING_ERR = __('The datasource seems to have been deleted')
+DATASOURCE_MISSING_ERR = __('The data source seems to have been deleted')
 ACCESS_REQUEST_MISSING_ERR = __(
     'The access requests seem to have been deleted')
 USER_MISSING_ERR = __('The user seems to have been deleted')
@@ -571,7 +571,7 @@ class DashboardModelView(SupersetModelView, DeleteMixin):  # noqa
             'the widgets size and positions by using drag & drop in '
             'the dashboard view'),
         'css': _(
-            'The css for individual dashboards can be altered here, or '
+            'The CSS for individual dashboards can be altered here, or '
             'in the dashboard view where changes are immediately '
             'visible'),
         'slug': _('To get a readable URL for your dashboard'),


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org