You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@livy.apache.org by GitBox <gi...@apache.org> on 2020/04/16 20:09:13 UTC

[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #290: [LIVY-758] Document how to attach to an existing session from Java client

mgaido91 commented on a change in pull request #290: [LIVY-758] Document how to attach to an existing session from Java client
URL: https://github.com/apache/incubator-livy/pull/290#discussion_r409813168
 
 

 ##########
 File path: api/src/main/java/org/apache/livy/LivyClientBuilder.java
 ##########
 @@ -36,9 +36,10 @@
 public final class LivyClientBuilder {
 
   public static final String LIVY_URI_KEY = "livy.uri";
+  public static final String LIVY_SESSION_ID_KEY = "livy.sessionId";
 
   private static final ServiceLoader<LivyClientFactory> CLIENT_FACTORY_LOADER =
-    ServiceLoader.load(LivyClientFactory.class, classLoader());
+      ServiceLoader.load(LivyClientFactory.class, classLoader());
 
 Review comment:
   nit: unneeded change, please revert

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services