You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by markap14 <gi...@git.apache.org> on 2018/01/12 19:13:16 UTC
[GitHub] nifi pull request #2403: NIFI-4772: Refactored how the @OnScheduled methods ...
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/2403
NIFI-4772: Refactored how the @OnScheduled methods of processors is i…
…nvoked/monitored. The new method does away with the two previously created 8-thread thread pools and just uses the Timer-Driven thread pool that is used by other framework tasks.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-4772
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2403.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2403
----
commit c59645e0bc780ca3f2f997437902fe4e498f528d
Author: Mark Payne <ma...@...>
Date: 2018-01-12T19:12:57Z
NIFI-4772: Refactored how the @OnScheduled methods of processors is invoked/monitored. The new method does away with the two previously created 8-thread thread pools and just uses the Timer-Driven thread pool that is used by other framework tasks.
----
---
[GitHub] nifi issue #2403: NIFI-4772: Refactored how the @OnScheduled methods of proc...
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/2403
I think it makes sense to have the tasks which check the status of component scheduling/unscheduling/etc.. be done in an administrative pool whereby they cannot get blocked/excluded from running in case the primary timer driven pool is exhausted with slow starting items.
---
[GitHub] nifi pull request #2403: NIFI-4772: Refactored how the @OnScheduled methods ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2403
---
[GitHub] nifi issue #2403: NIFI-4772: Refactored how the @OnScheduled methods of proc...
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2403
+1 LGTM, ran unit tests and tried many different scenarios in a running NiFi (before and after the QueryDatabaseTable issue was fixed) under various OnScheduled error conditions. Thanks for the improvement! Merging to master
---
[GitHub] nifi pull request #2403: NIFI-4772: Refactored how the @OnScheduled methods ...
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2403#discussion_r163398903
--- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/scheduling/StandardProcessScheduler.java ---
@@ -24,6 +24,7 @@
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.ConcurrentMap;
+import java.util.concurrent.Executors;
--- End diff --
Unused import, will remove on merge
---
[GitHub] nifi issue #2403: NIFI-4772: Refactored how the @OnScheduled methods of proc...
Posted by markap14 <gi...@git.apache.org>.
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2403
@joewitt i agree. I did push another commit that addresses that.
---