You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Jason Dillon (JIRA)" <ji...@apache.org> on 2007/10/06 13:43:51 UTC

[jira] Created: (GSHELL-36) The clp does not allow --help to execute if a required argument or option is configured

The clp does not allow --help to execute if a required argument or option is configured
---------------------------------------------------------------------------------------

                 Key: GSHELL-36
                 URL: https://issues.apache.org/jira/browse/GSHELL-36
             Project: GShell
          Issue Type: Bug
      Security Level: public (Regular issues)
    Affects Versions: 1.0-alpha-1
            Reporter: Jason Dillon
            Assignee: Jason Dillon
             Fix For: 1.0-alpha-1




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GSHELL-36) The clp does not allow --help to execute if a required argument or option is configured

Posted by "Jason Dillon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GSHELL-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539734 ] 

Jason Dillon commented on GSHELL-36:
------------------------------------

Cool, will take a look this evening.  Thanks :-)

> The clp does not allow --help to execute if a required argument or option is configured
> ---------------------------------------------------------------------------------------
>
>                 Key: GSHELL-36
>                 URL: https://issues.apache.org/jira/browse/GSHELL-36
>             Project: GShell
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>    Affects Versions: 1.0-alpha-1
>            Reporter: Jason Dillon
>            Assignee: Jason Warner
>             Fix For: 1.0-alpha-1
>
>         Attachments: GShell-36.patch, GShell-36AnnotationChange.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (GSHELL-36) The clp does not allow --help to execute if a required argument or option is configured

Posted by "Jason Dillon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GSHELL-36?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Dillon closed GSHELL-36.
------------------------------

    Resolution: Fixed

> The clp does not allow --help to execute if a required argument or option is configured
> ---------------------------------------------------------------------------------------
>
>                 Key: GSHELL-36
>                 URL: https://issues.apache.org/jira/browse/GSHELL-36
>             Project: GShell
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>    Affects Versions: 1.0-alpha-1
>            Reporter: Jason Dillon
>            Assignee: Jason Warner
>             Fix For: 1.0-alpha-1
>
>         Attachments: GShell-36.patch, GShell-36AnnotationChange.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (GSHELL-36) The clp does not allow --help to execute if a required argument or option is configured

Posted by "Jason Dillon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GSHELL-36?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Dillon reopened GSHELL-36:
--------------------------------


Seems like this change does not jive well with commands that use required arguments, like {{rshd}}.

> The clp does not allow --help to execute if a required argument or option is configured
> ---------------------------------------------------------------------------------------
>
>                 Key: GSHELL-36
>                 URL: https://issues.apache.org/jira/browse/GSHELL-36
>             Project: GShell
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>    Affects Versions: 1.0-alpha-1
>            Reporter: Jason Dillon
>            Assignee: Jason Warner
>             Fix For: 1.0-alpha-1
>
>         Attachments: GShell-36.patch, GShell-36AnnotationChange.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (GSHELL-36) The clp does not allow --help to execute if a required argument or option is configured

Posted by "Jason Dillon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GSHELL-36?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Dillon updated GSHELL-36:
-------------------------------

    Priority: Blocker  (was: Major)

> The clp does not allow --help to execute if a required argument or option is configured
> ---------------------------------------------------------------------------------------
>
>                 Key: GSHELL-36
>                 URL: https://issues.apache.org/jira/browse/GSHELL-36
>             Project: GShell
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>    Affects Versions: 1.0-alpha-1
>            Reporter: Jason Dillon
>            Assignee: Jason Dillon
>            Priority: Blocker
>             Fix For: 1.0-alpha-1
>
>         Attachments: GShell-36.patch, GShell-36AnnotationChange.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (GSHELL-36) The clp does not allow --help to execute if a required argument or option is configured

Posted by "Jason Warner (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GSHELL-36?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Warner updated GSHELL-36:
-------------------------------

    Attachment: GShell-36AnnotationChange.patch

I gave it another shot with the annotation change.  I like it better this way.  It feels neater.

> The clp does not allow --help to execute if a required argument or option is configured
> ---------------------------------------------------------------------------------------
>
>                 Key: GSHELL-36
>                 URL: https://issues.apache.org/jira/browse/GSHELL-36
>             Project: GShell
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>    Affects Versions: 1.0-alpha-1
>            Reporter: Jason Dillon
>            Assignee: Jason Warner
>             Fix For: 1.0-alpha-1
>
>         Attachments: GShell-36.patch, GShell-36AnnotationChange.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (GSHELL-36) The clp does not allow --help to execute if a required argument or option is configured

Posted by "Jason Dillon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GSHELL-36?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Dillon reassigned GSHELL-36:
----------------------------------

    Assignee: Jason Dillon  (was: Jason Warner)

> The clp does not allow --help to execute if a required argument or option is configured
> ---------------------------------------------------------------------------------------
>
>                 Key: GSHELL-36
>                 URL: https://issues.apache.org/jira/browse/GSHELL-36
>             Project: GShell
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>    Affects Versions: 1.0-alpha-1
>            Reporter: Jason Dillon
>            Assignee: Jason Dillon
>             Fix For: 1.0-alpha-1
>
>         Attachments: GShell-36.patch, GShell-36AnnotationChange.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GSHELL-36) The clp does not allow --help to execute if a required argument or option is configured

Posted by "Jason Dillon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GSHELL-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539202 ] 

Jason Dillon commented on GSHELL-36:
------------------------------------

Coolio... I will take a peek at this soon.  I do think however that the anno should probably be changed to have a requireOverride or something flag.

Or perhaps the action of setting the help option can display the help text and then signal the command to complete or something?

> The clp does not allow --help to execute if a required argument or option is configured
> ---------------------------------------------------------------------------------------
>
>                 Key: GSHELL-36
>                 URL: https://issues.apache.org/jira/browse/GSHELL-36
>             Project: GShell
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>    Affects Versions: 1.0-alpha-1
>            Reporter: Jason Dillon
>            Assignee: Jason Warner
>             Fix For: 1.0-alpha-1
>
>         Attachments: GShell-36.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (GSHELL-36) The clp does not allow --help to execute if a required argument or option is configured

Posted by "Jason Dillon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GSHELL-36?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Dillon reassigned GSHELL-36:
----------------------------------

    Assignee:     (was: Jason Dillon)

> The clp does not allow --help to execute if a required argument or option is configured
> ---------------------------------------------------------------------------------------
>
>                 Key: GSHELL-36
>                 URL: https://issues.apache.org/jira/browse/GSHELL-36
>             Project: GShell
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>    Affects Versions: 1.0-alpha-1
>            Reporter: Jason Dillon
>             Fix For: 1.0-alpha-1
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GSHELL-36) The clp does not allow --help to execute if a required argument or option is configured

Posted by "Jason Dillon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GSHELL-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12540591 ] 

Jason Dillon commented on GSHELL-36:
------------------------------------

Testing now... gonna apply the anno patch as soon as I can verify its all happy.  Thanks :-)

> The clp does not allow --help to execute if a required argument or option is configured
> ---------------------------------------------------------------------------------------
>
>                 Key: GSHELL-36
>                 URL: https://issues.apache.org/jira/browse/GSHELL-36
>             Project: GShell
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>    Affects Versions: 1.0-alpha-1
>            Reporter: Jason Dillon
>            Assignee: Jason Warner
>             Fix For: 1.0-alpha-1
>
>         Attachments: GShell-36.patch, GShell-36AnnotationChange.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (GSHELL-36) The clp does not allow --help to execute if a required argument or option is configured

Posted by "Jason Dillon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GSHELL-36?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Dillon closed GSHELL-36.
------------------------------

    Resolution: Fixed

Only override requirements if the handler is processed

> The clp does not allow --help to execute if a required argument or option is configured
> ---------------------------------------------------------------------------------------
>
>                 Key: GSHELL-36
>                 URL: https://issues.apache.org/jira/browse/GSHELL-36
>             Project: GShell
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>    Affects Versions: 1.0-alpha-1
>            Reporter: Jason Dillon
>            Assignee: Jason Dillon
>            Priority: Blocker
>             Fix For: 1.0-alpha-1
>
>         Attachments: GShell-36.patch, GShell-36AnnotationChange.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (GSHELL-36) The clp does not allow --help to execute if a required argument or option is configured

Posted by "Jason Warner (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GSHELL-36?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Warner reassigned GSHELL-36:
----------------------------------

    Assignee: Jason Warner

> The clp does not allow --help to execute if a required argument or option is configured
> ---------------------------------------------------------------------------------------
>
>                 Key: GSHELL-36
>                 URL: https://issues.apache.org/jira/browse/GSHELL-36
>             Project: GShell
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>    Affects Versions: 1.0-alpha-1
>            Reporter: Jason Dillon
>            Assignee: Jason Warner
>             Fix For: 1.0-alpha-1
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (GSHELL-36) The clp does not allow --help to execute if a required argument or option is configured

Posted by "Jason Warner (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GSHELL-36?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Warner updated GSHELL-36:
-------------------------------

    Attachment: GShell-36.patch

This patch solves the issue that this jira was created for.  You can now use the help option on commands that have required options without including the required options.  I'm not sure how elegant this solution is.  I had another idea that involved creating a new field in the option annotation to act as a flag if the option is for the help command.  I was hesitant to change an annotation though.  If this would be a more desirable option, let me know and I'll throw up a new patch that works that way.  Now that I understand what's going on in this area of the code, that change would be quick and easy.

> The clp does not allow --help to execute if a required argument or option is configured
> ---------------------------------------------------------------------------------------
>
>                 Key: GSHELL-36
>                 URL: https://issues.apache.org/jira/browse/GSHELL-36
>             Project: GShell
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>    Affects Versions: 1.0-alpha-1
>            Reporter: Jason Dillon
>            Assignee: Jason Warner
>             Fix For: 1.0-alpha-1
>
>         Attachments: GShell-36.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.