You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mina.apache.org by "Lyor Goldstein (Jira)" <ji...@apache.org> on 2021/11/20 07:00:00 UTC

[jira] [Closed] (SSHD-1081) Avoid unused interfaces

     [ https://issues.apache.org/jira/browse/SSHD-1081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lyor Goldstein closed SSHD-1081.
--------------------------------
    Resolution: Won't Do

> Avoid unused interfaces
> -----------------------
>
>                 Key: SSHD-1081
>                 URL: https://issues.apache.org/jira/browse/SSHD-1081
>             Project: MINA SSHD
>          Issue Type: Improvement
>            Reporter: Guillaume Nodet
>            Priority: Major
>
> I think over time, we've added a bunch of interfaces which are not really useful at the end.
> Adding interfaces purely to abstract methods is imho not a good idea when they don't represent something which is actually used.  It makes the navigation in the code much more difficult when trying to find the correct implementation of a given method.   A good example is imho {{SessionHolder}} or {{ClientSessionHolder}} which are implemented by a lot of classes but never actually used as a parameter or or variable.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org