[PR] feat(runtime): revive resource authority admission and fix review races [maka]

["Jarad-z (via GitHub)" <gi...@apache.org>]

Jarad-z opened a new pull request, #6084:
URL: https://github.com/apache/maka/pull/6084

   ## Summary
   Revives #4542 (head 117232fde4c5c5dbfffababb91f17a6a41ab7e0e) on main at a393c5065e56cc083ca3d41943828f80f181f6f6. The original had conflicts in 13 files and four unresolved correctness findings. This draft retains its authority-owned resource admission and deterministic provider-batch sequencing; it does not close the original PR.
   
   - Preserve the admitted missing identity for local deletes, so a file appearing before the effect is rejected rather than removed.
   - Keep human questions and sandbox-boundary interactions outside the process-exclusive barrier, under the existing Session interaction owner.
   - Acquire the complete path lease set before the complete observed inode lease set, revalidate after admission, and coordinate exact reads/writes through hard links across owners and patch batches.
   - Preserve the first fatal rejection in cancelled queue slots so provider-order settlement cannot hide its cause.
   - Adapt plugin/model composition, live permission reads, Code Mode, bounded Read continuations and image sniffing, Grep completeness, Glob truncation, and worker protocol v12 to current main. Keep current mutation/outcome and recovery behavior.
   - Retain admission-relative mutable identity: create → read and replacement → read remain valid. Provider order breaks resource conflicts; it does not imply data dependencies.
   
   Refs #4487. Todo/Goal/Plan, terminal/browser authorities, provider capacity and multi-resource transactions remain deferred. Tree searches coordinate by path, not a snapshot against aliases outside the searched tree; external workspaces without pinned handles retain their weaker contract.
   
   ## Verification
   Linux, Node 24.19.0 / npm 11.9.0 (the repository specifies npm 11.19.0):
   - Full npm run build, npm run typecheck, npm run lint, npm run format:check, npm run check:asf-headers, both required desktop/UI knip checks, and git diff --check: passed.
   - Final affected Runtime matrix: 609 passed, 0 failed. Includes filesystem authority/admission/worker/CAS suites, scheduler/batch/preparation, builtin authority access, AiSdkBackend and Code Mode. Three new parity tests preserve Read pagination/continuations, Grep counts and Glob truncation.
   - Runtime Host lease/model/profile composition: 49 passed, 0 failed.
   - Negative verification: removing the four review fixes in an isolated compiled copy makes all six corresponding regression cases fail; the three result-contract cases still pass.
   - Broader builtin matrix: 368 passed, 2 failed. Both failures (wraps managed pipe Bash with bubblewrap argv and seccomp fd input; requires an approved network expansion before declared Bash network access) reproduce on exact unmodified base a393c506 with An approved sandbox path could not be pinned safely.
   - State-root/OS-home fixtures required execution outside the workspace-only filesystem sandbox. No production behavior was weakened for these tests.
   - Full all-workspace test suite, native Windows/macOS, remote workspaces and hosted CI are not claimed green. The old September Windows report is marked historical.
   
   The old head's five GitHub workflows report failure with zero jobs, which is not evidence of an assertion failure. This draft still needs the required hosted test gate and an independent human committer review; a maintainer may need to authorize fork workflow execution.
   
   ## AI use
   - [ ] No generative tool made a substantive contribution
   - [x] Generative tooling made a substantive contribution
   
   Tool(s) and scope: Codex assisted with investigation, forward-porting, fixes, regression tests and PR preparation. This is an automated submission on the contributor's explicit instruction; it does not replace human review. The commit includes a Generated-by: Codex trailer.
   
   ## Checklist
   - [x] Tests cover the change and fail without it
   - [ ] Lint, format, typecheck and the affected suites pass locally (two base-reproduced sandbox fixture failures documented above)
   
   Does this PR entail a change in behavior?
   - [x] Yes — described under Summary above
   - [ ] No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org