[jira] [Commented] (HBASE-23749) TestHFileWriterV3 should have tests for all data block encodings

["Viraj Jasani (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-23749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17024848#comment-17024848 ] 

Viraj Jasani commented on HBASE-23749:
--------------------------------------

FYI [~ram_krish]

> TestHFileWriterV3 should have tests for all data block encodings
> ----------------------------------------------------------------
>
>                 Key: HBASE-23749
>                 URL: https://issues.apache.org/jira/browse/HBASE-23749
>             Project: HBase
>          Issue Type: Test
>    Affects Versions: 3.0.0, 2.3.0, 1.6.0
>            Reporter: Viraj Jasani
>            Assignee: Viraj Jasani
>            Priority: Major
>
> TestHFileWriterV3 tests include writing and reading HFiles for default data blocks encoding. However, since this test has efficient way of testing by looping through encoded/un-encoded keys and values and keeping offsets updated etc, it would be really good to have such test for each encoded data blocks. For that, we should explore using respective seekers e.g. RowIndexV1Seeker for ROW_INDEX_V1 encoded data blocks etc.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)