You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/09/28 12:44:16 UTC

[GitHub] [spark] srowen commented on a diff in pull request #38024: [SPARK-40591][CORE][SQL] Fix data loss caused by ignoreCorruptFiles

srowen commented on code in PR #38024:
URL: https://github.com/apache/spark/pull/38024#discussion_r982356825


##########
core/src/main/scala/org/apache/spark/internal/config/package.scala:
##########
@@ -1078,6 +1078,13 @@ package object config {
     .booleanConf
     .createWithDefault(false)
 
+  private[spark] val IGNORE_CORRUPT_FILES_AFTER_RETIES =

Review Comment:
   Do we really need another config?
   I'm sorta confused, isn't the file effectively 'corrupt' in this case, and you have asked to ignore that?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org