You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by prasadwagle <gi...@git.apache.org> on 2016/04/22 02:59:38 UTC
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-820] Reduce websocket c...
GitHub user prasadwagle opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/850
[ZEPPELIN-820] Reduce websocket communication by unicasting instead of broadcasting note list
### What is this PR for?
Reducing websocket communication by unicasting instead of broadcasting notes list reduces probability of deadlock in jetty8 and also improves response time.
### What type of PR is it?
Improvement
### Todos
### What is the Jira issue?
[ZEPPELIN-820] (https://issues.apache.org/jira/browse/ZEPPELIN-820)
### How should this be tested?
1. Open two browser windows.
2. Check if note list shows up on home page.
3. Check if creating, removing note in one window results in updates to notes list in other windows.
### Screenshots (if appropriate)
### Questions:
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prasadwagle/incubator-zeppelin ZEPPELIN-820
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/850.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #850
----
commit f249ac1d3b1c4ae39b329a785ec45368ca433e8d
Author: Prasad Wagle <pw...@twitter.com>
Date: 2016-04-22T00:53:32Z
[ZEPPELIN-820] Reduce websocket communication by unicasting instead of broadcasting note list
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-820] Reduce websocket c...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/850
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-820] Reduce websocket c...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/850#issuecomment-215944181
This PR does not update note title in the menu and main page, when title is changed.
Try change note title and see list of note in the menu and main page.
I think broadcastNoteList need to be called when note title is updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-820] Reduce websocket c...
Posted by prasadwagle <gi...@git.apache.org>.
Github user prasadwagle closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/850
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-820] Reduce websocket c...
Posted by prasadwagle <gi...@git.apache.org>.
GitHub user prasadwagle reopened a pull request:
https://github.com/apache/incubator-zeppelin/pull/850
[ZEPPELIN-820] Reduce websocket communication by unicasting instead of broadcasting note list
### What is this PR for?
Reducing websocket communication by unicasting instead of broadcasting notes list reduces probability of deadlock in jetty8 and also improves response time.
### What type of PR is it?
Improvement
### Todos
### What is the Jira issue?
[ZEPPELIN-820] (https://issues.apache.org/jira/browse/ZEPPELIN-820)
### How should this be tested?
1. Open two browser windows.
2. Check if note list shows up on home page.
3. Check if creating, removing note in one window results in updates to notes list in other windows.
### Screenshots (if appropriate)
### Questions:
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prasadwagle/incubator-zeppelin ZEPPELIN-820
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/850.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #850
----
commit f249ac1d3b1c4ae39b329a785ec45368ca433e8d
Author: Prasad Wagle <pw...@twitter.com>
Date: 2016-04-22T00:53:32Z
[ZEPPELIN-820] Reduce websocket communication by unicasting instead of broadcasting note list
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-820] Reduce websocket c...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/850#issuecomment-217051020
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-820] Reduce websocket c...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/850#issuecomment-217239266
Merge if there're no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-820] Reduce websocket c...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/850#issuecomment-213201586
Test failure looks quite strange
```
[INFO] Building Zeppelin: Server 0.6.0-incubating-SNAPSHOT
...
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Running org.apache.zeppelin.rest.ZeppelinSparkClusterTest
....
01:13:27,991 INFO org.apache.zeppelin.socket.NotebookServer:1110 - Job 20160422-011317_510294549 is finished
01:13:28,015 INFO org.apache.zeppelin.notebook.Paragraph:235 - run paragraph 20160422-011328_1891493426 using pyspark org.apache.zeppelin.interpreter.LazyOpenInterpreter@2373e70d
No output has been received in the last 10 minutes, this potentially indicates a stalled build or something wrong with the build itself.
The build has been terminated
```
@prasadwagle could you please close and re-opening the PR again to trigger a CI and see if this deserves a JIRA issue with `flaky-test` label?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-820] Reduce websocket c...
Posted by prasadwagle <gi...@git.apache.org>.
Github user prasadwagle commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/850#issuecomment-213580839
@bzz New build succeeded. Created [ZEPPELIN-822](https://issues.apache.org/jira/browse/ZEPPELIN-822) - Flaky test - org.apache.zeppelin.rest.ZeppelinSparkClusterTest
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---