[GitHub] [qpid-proton] cliffjansen commented on pull request #337: PROTON-2406: [cpp] Replace uses of deprecated reconnect_options::failover_urls with conn…

[GitBox <gi...@apache.org>]

cliffjansen commented on pull request #337:
URL: https://github.com/apache/qpid-proton/pull/337#issuecomment-956502433


   As I read the documentation for reconnect_url() and failover_urls() I implicitly expect the same intention for:
   
     - default reconnect timing options
     - change via update_options()
   
   even though it is only explicitly spelled out for the former and may not make sense in all permutations for the latter.  Perhaps the documentation should be made explicit for failover_urls().
   
   Regardless, I think I would expect this example to have no reference to reconnect_options unless non-default values were being set and no call made to connection::reconnect().
   
   The segfault appears to be from a missing argument where argc is one short to catch the expected number of input parameters.  However, it may also be a failing in the library to not robustly handle an empty vector properly.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org