You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2019/11/01 05:25:49 UTC
[kudu-CR] KUDU-2989. Work around SASL bug when FQDN is >d characters
Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14609
Change subject: KUDU-2989. Work around SASL bug when FQDN is >=64 characters
......................................................................
KUDU-2989. Work around SASL bug when FQDN is >=64 characters
This adds a workaround for an upstream SASL bug which is triggered when
the FQDN has more than 64 characters. In this case, SASL would truncate
the FQDN and not be able to find the relevant keytab.
The workaround simply uses our own code to determine the FQDN.
Change-Id: I4898814f2f7ab87151798336414dde7078d28a4a
---
M src/kudu/rpc/server_negotiation.cc
1 file changed, 14 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/14609/1
--
To view, visit http://gerrit.cloudera.org:8080/14609
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4898814f2f7ab87151798336414dde7078d28a4a
Gerrit-Change-Number: 14609
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-2989. Work around SASL bug when FQDN is >d characters
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14609 )
Change subject: KUDU-2989. Work around SASL bug when FQDN is >=64 characters
......................................................................
KUDU-2989. Work around SASL bug when FQDN is >=64 characters
This adds a workaround for an upstream SASL bug which is triggered when
the FQDN has more than 64 characters. In this case, SASL would truncate
the FQDN and not be able to find the relevant keytab.
The workaround simply uses our own code to determine the FQDN.
Change-Id: I4898814f2f7ab87151798336414dde7078d28a4a
Reviewed-on: http://gerrit.cloudera.org:8080/14609
Reviewed-by: Anurag Mantripragada <an...@cloudera.com>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/rpc/server_negotiation.cc
1 file changed, 14 insertions(+), 1 deletion(-)
Approvals:
Anurag Mantripragada: Looks good to me, but someone else must approve
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14609
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4898814f2f7ab87151798336414dde7078d28a4a
Gerrit-Change-Number: 14609
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-2989. Work around SASL bug when FQDN is >d characters
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14609 )
Change subject: KUDU-2989. Work around SASL bug when FQDN is >=64 characters
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14609/1/src/kudu/rpc/server_negotiation.cc
File src/kudu/rpc/server_negotiation.cc:
http://gerrit.cloudera.org:8080/#/c/14609/1/src/kudu/rpc/server_negotiation.cc@409
PS1, Line 409: server_fqdn,
Is it OK for the memory behind this to go out of scope when InitSaslServer finishes? Does sasl_server_new make a copy of it?
Looking at the sasl code itself, I think the answer is "yes".
--
To view, visit http://gerrit.cloudera.org:8080/14609
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4898814f2f7ab87151798336414dde7078d28a4a
Gerrit-Change-Number: 14609
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 01 Nov 2019 05:42:13 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2989. Work around SASL bug when FQDN is >d characters
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14609 )
Change subject: KUDU-2989. Work around SASL bug when FQDN is >=64 characters
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14609/1/src/kudu/rpc/server_negotiation.cc
File src/kudu/rpc/server_negotiation.cc:
http://gerrit.cloudera.org:8080/#/c/14609/1/src/kudu/rpc/server_negotiation.cc@409
PS1, Line 409: server_fqdn,
> Is it OK for the memory behind this to go out of scope when InitSaslServer
Yea, it strdups it
--
To view, visit http://gerrit.cloudera.org:8080/14609
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4898814f2f7ab87151798336414dde7078d28a4a
Gerrit-Change-Number: 14609
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 01 Nov 2019 05:51:26 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2989. Work around SASL bug when FQDN is >d characters
Posted by "Anurag Mantripragada (Code Review)" <ge...@cloudera.org>.
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14609 )
Change subject: KUDU-2989. Work around SASL bug when FQDN is >=64 characters
......................................................................
Patch Set 1: Code-Review+1
Looks good to me.
--
To view, visit http://gerrit.cloudera.org:8080/14609
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4898814f2f7ab87151798336414dde7078d28a4a
Gerrit-Change-Number: 14609
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 01 Nov 2019 05:39:19 +0000
Gerrit-HasComments: No