You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/06/29 02:09:17 UTC
[GitHub] [cordova-lib] erisu opened a new pull request #839: chore: remove nightly packages from testing scope
erisu opened a new pull request #839:
URL: https://github.com/apache/cordova-lib/pull/839
### Motivation, Context & Description
- Remove the nightly packages from testing that was used temporarily
- Use actual released packages
### Testing
- `npm t`
### Checklist
- [x] I've run the tests to see all new and existing tests pass
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-lib] codecov-commenter commented on pull request #839: chore: remove nightly packages from testing scope
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #839:
URL: https://github.com/apache/cordova-lib/pull/839#issuecomment-650871472
# [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/839?src=pr&el=h1) Report
> Merging [#839](https://codecov.io/gh/apache/cordova-lib/pull/839?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-lib/commit/7a20be8b67ee221e5e7c637ee1a7a18338619d76&el=desc) will **decrease** coverage by `0.41%`.
> The diff coverage is `91.30%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/cordova-lib/pull/839/graphs/tree.svg?width=650&height=150&src=pr&token=KwBjKMXLqA)](https://codecov.io/gh/apache/cordova-lib/pull/839?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #839 +/- ##
==========================================
- Coverage 89.96% 89.55% -0.42%
==========================================
Files 46 46
Lines 2133 2097 -36
==========================================
- Hits 1919 1878 -41
- Misses 214 219 +5
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-lib/pull/839?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/util/promise-util.js](https://codecov.io/gh/apache/cordova-lib/pull/839/diff?src=pr&el=tree#diff-c3JjL3V0aWwvcHJvbWlzZS11dGlsLmpz) | `100.00% <ø> (+16.66%)` | :arrow_up: |
| [src/cordova/restore-util.js](https://codecov.io/gh/apache/cordova-lib/pull/839/diff?src=pr&el=tree#diff-c3JjL2NvcmRvdmEvcmVzdG9yZS11dGlsLmpz) | `92.50% <91.30%> (-1.46%)` | :arrow_down: |
| [src/plugman/util/dependencies.js](https://codecov.io/gh/apache/cordova-lib/pull/839/diff?src=pr&el=tree#diff-c3JjL3BsdWdtYW4vdXRpbC9kZXBlbmRlbmNpZXMuanM=) | `92.10% <0.00%> (-2.64%)` | :arrow_down: |
| [src/plugman/install.js](https://codecov.io/gh/apache/cordova-lib/pull/839/diff?src=pr&el=tree#diff-c3JjL3BsdWdtYW4vaW5zdGFsbC5qcw==) | `90.87% <0.00%> (-1.59%)` | :arrow_down: |
| [src/cordova/platform/addHelper.js](https://codecov.io/gh/apache/cordova-lib/pull/839/diff?src=pr&el=tree#diff-c3JjL2NvcmRvdmEvcGxhdGZvcm0vYWRkSGVscGVyLmpz) | `94.73% <0.00%> (-1.32%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-lib/pull/839?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/839?src=pr&el=footer). Last update [909e7c7...62f1f47](https://codecov.io/gh/apache/cordova-lib/pull/839?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-lib] erisu merged pull request #839: chore: remove nightly packages from testing scope
Posted by GitBox <gi...@apache.org>.
erisu merged pull request #839:
URL: https://github.com/apache/cordova-lib/pull/839
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org