You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2026/06/14 17:46:42 UTC
svn commit: r1935315 - pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/pdfwriter
Author: tilman
Date: Sun Jun 14 17:46:42 2026
New Revision: 1935315
Log:
PDFBOX-5660: Sonar fix
Modified:
pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/pdfwriter/COSWriterCompressionPoolTest.java
pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/pdfwriter/COSWriterTest.java
Modified: pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/pdfwriter/COSWriterCompressionPoolTest.java
==============================================================================
--- pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/pdfwriter/COSWriterCompressionPoolTest.java Sun Jun 14 16:38:02 2026 (r1935314)
+++ pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/pdfwriter/COSWriterCompressionPoolTest.java Sun Jun 14 17:46:42 2026 (r1935315)
@@ -23,6 +23,8 @@ import org.apache.pdfbox.pdfwriter.compr
import org.apache.pdfbox.pdmodel.PDDocument;
import org.apache.pdfbox.pdmodel.interactive.documentnavigation.outline.PDDocumentOutline;
import org.apache.pdfbox.pdmodel.interactive.documentnavigation.outline.PDOutlineItem;
+
+import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;
class COSWriterCompressionPoolTest
@@ -48,7 +50,8 @@ class COSWriterCompressionPoolTest
{
outline.addLast(new PDOutlineItem());
}
- new COSWriterCompressionPool(document, CompressParameters.DEFAULT_COMPRESSION);
+ Assertions.assertDoesNotThrow(() ->
+ new COSWriterCompressionPool(document, CompressParameters.DEFAULT_COMPRESSION));
}
}
}
Modified: pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/pdfwriter/COSWriterTest.java
==============================================================================
--- pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/pdfwriter/COSWriterTest.java Sun Jun 14 16:38:02 2026 (r1935314)
+++ pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/pdfwriter/COSWriterTest.java Sun Jun 14 17:46:42 2026 (r1935315)
@@ -16,6 +16,7 @@
*/
package org.apache.pdfbox.pdfwriter;
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNotNull;
@@ -46,6 +47,7 @@ import org.apache.pdfbox.pdmodel.font.St
import org.apache.pdfbox.pdmodel.interactive.annotation.PDAnnotationWidget;
import org.apache.pdfbox.pdmodel.interactive.form.PDAcroForm;
import org.apache.pdfbox.pdmodel.interactive.form.PDTextField;
+
import org.junit.jupiter.api.Test;
class COSWriterTest
@@ -60,17 +62,19 @@ class COSWriterTest
{
try (PDDocument doc = new PDDocument())
{
-
PDPage page = new PDPage();
doc.addPage(page);
- doc.save(new BufferedOutputStream(new ByteArrayOutputStream(1024)
+ assertDoesNotThrow(() ->
{
- @Override
- public void close() throws IOException
+ doc.save(new BufferedOutputStream(new ByteArrayOutputStream(1024)
{
- throw new IOException("Stream was closed");
- }
- }));
+ @Override
+ public void close() throws IOException
+ {
+ throw new IOException("Stream was closed");
+ }
+ }));
+ });
}
}
@@ -84,7 +88,7 @@ class COSWriterTest
PageExtractor pageExtractor = new PageExtractor(pdfDocument, 2, 2);
try (PDDocument pdfPages = pageExtractor.extract())
{
- pdfPages.save(new ByteArrayOutputStream());
+ assertDoesNotThrow(() -> pdfPages.save(new ByteArrayOutputStream()));
}
}
}