You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by pm...@apache.org on 2015/12/12 09:12:13 UTC

svn commit: r1719635 - /jmeter/trunk/build.xml

Author: pmouawad
Date: Sat Dec 12 08:12:12 2015
New Revision: 1719635

URL: http://svn.apache.org/viewvc?rev=1719635&view=rev
Log:
Create target with checkstyle to avoid commiting files that do not respect formating rules

Modified:
    jmeter/trunk/build.xml

Modified: jmeter/trunk/build.xml
URL: http://svn.apache.org/viewvc/jmeter/trunk/build.xml?rev=1719635&r1=1719634&r2=1719635&view=diff
==============================================================================
--- jmeter/trunk/build.xml (original)
+++ jmeter/trunk/build.xml Sat Dec 12 08:12:12 2015
@@ -871,6 +871,9 @@
   <target name="package" depends="compile, prepare-resources, package-only"
      description="Compile everything and create the jars"/>
 
+  <target name="package-and-check" depends="package, checkstyle" 
+     description="Compile, create jars and apply checkstyle before commiting code"/>
+
   <target name="prepare-resources"
      description="Prepare some resources files, update date">
     <mkdir dir="${build.res}" />



Re: svn commit: r1719635 - /jmeter/trunk/build.xml

Posted by sebb <se...@gmail.com>.
On 12 December 2015 at 08:12,  <pm...@apache.org> wrote:
> Author: pmouawad
> Date: Sat Dec 12 08:12:12 2015
> New Revision: 1719635
>
> URL: http://svn.apache.org/viewvc?rev=1719635&view=rev
> Log:
> Create target with checkstyle to avoid commiting files that do not respect formating rules

-0.9

The target is unnecessary, as one can just do

ant checkstyle package

> Modified:
>     jmeter/trunk/build.xml
>
> Modified: jmeter/trunk/build.xml
> URL: http://svn.apache.org/viewvc/jmeter/trunk/build.xml?rev=1719635&r1=1719634&r2=1719635&view=diff
> ==============================================================================
> --- jmeter/trunk/build.xml (original)
> +++ jmeter/trunk/build.xml Sat Dec 12 08:12:12 2015
> @@ -871,6 +871,9 @@
>    <target name="package" depends="compile, prepare-resources, package-only"
>       description="Compile everything and create the jars"/>
>
> +  <target name="package-and-check" depends="package, checkstyle"
> +     description="Compile, create jars and apply checkstyle before commiting code"/>
> +
>    <target name="prepare-resources"
>       description="Prepare some resources files, update date">
>      <mkdir dir="${build.res}" />
>
>