[GitHub] dubee commented on a change in pull request #353: Create triggers on update if do not exist

[GitBox <gi...@apache.org>]

dubee commented on a change in pull request #353: Create triggers on update if do not exist
URL: https://github.com/apache/incubator-openwhisk-cli/pull/353#discussion_r245350751
 
 

 ##########
 File path: commands/trigger.go
 ##########
 @@ -75,7 +77,7 @@ func feedParameters(feed string, lifecycle string, trigger *QualifiedName, authK
  *
  * NOTE: this function will exit in case of a processing error since it indicates a problem parsing parameters.
  */
-func createOrUpdate(fqn *QualifiedName, trigger *whisk.Trigger, overwrite bool) {
+func createOrUpdate(Client *whisk.Client, fqn *QualifiedName, trigger *whisk.Trigger, overwrite bool) {
 
 Review comment:
   Now that `Client` is a parameter, can we delete the comment `// TODO get rid of these global modifiers`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services